Fix/mission item altitude#114
Conversation
angel-ayala
left a comment
There was a problem hiding this comment.
Nice work @TimonSchreiber , the only comment that I have is regards the title. The addressed changes make sense to me, but were focused on mission items altitude instead the aircraft take off. So I will update the PR title.
I agree that #112 must be merged first.
What worries me the most is if such changes were already tested with the aircraft.
I was also aimed to address the problem with the altitude during take off, focused on the take off action that can be triggered from QGC, but I haven't tested it yet. I will open a PR of such changes to check and compare in case of requiring to update other lines.
|
Definitely a better name for this pr. Do you mean, you are worried to approve this without tests or what the latest test flights say about this problem? |
|
Yes, my worry is about approve the PR without testing. But if all seems to be ok, maybe a new PR can be opened with a better fix. |
d539640 to
62fe90d
Compare
angel-ayala
left a comment
There was a problem hiding this comment.
Nice work, everything seems to be ok. Ready to merge.
Fixes #107
Changes
Branched off #112 and intended to be merged after it, since both touch the mission upload path. Will rebase onto develop once #112 lands.