fix(reports): pack reset layout by row height to stop tile overlap#85
Merged
Conversation
buildDefaultLayout advanced each row by a fixed DEFAULT_H, so sections whose content auto-grows past 5 rows overlapped the next row and RGL's compactor shoved tiles around on Reset. Pack rows by their tallest tile and seed reset with already-measured heights instead of clearing them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Reports page, clicking Reset while customizing restored the default
section positions, but tiles overlapped and shoved each other around, with wrong
sizes.
Cause
buildDefaultLayoutadvanced each grid row by a fixedDEFAULT_H(5 rows), buttiles auto-grow to their content height via
fitHeights. A section taller than 5rows overlapped the next row, and the RGL compactor reshuffled everything. Reset
also cleared
minHeights, so heights collapsed to defaults before re-measuring,amplifying the jump.
Fix
so growing a tile never overlaps the next row.
minHeightsinstead of clearing them,removing the collapse-then-regrow flicker.
Verification
npx tsc --noEmitclean. Manual: Reports > Customize > drag/resize > Reset, tilessnap to defaults cleanly with no jumping.
🤖 Generated with Claude Code