Skip to content

Add image artist #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
H4lfbeard merged 3 commits into from
Nov 27, 2024
Merged

Add image artist #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6052632
commit artist img to pull
H4lfbeard Nov 25, 2024
d3db2a9
add image artist plus new image explore
H4lfbeard Nov 25, 2024
4ed2f80
add artist image
H4lfbeard Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified client/src/assets/background-images/concert.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions client/src/components/DisplayAlbums/DisplayAlbums.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ section.albums-section ul li {
flex-direction: column;
align-items: center;
border-bottom: none;
cursor: auto;
}
section.albums-section ul li img {
border-radius: 1rem;
Expand Down
34 changes: 34 additions & 0 deletions client/src/components/DisplayTracks/DisplayTracks.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,26 @@
article.background-image {
width: 100%;
height: 45rem;
background-repeat: repeat;
background-size: 50%;
background-position: center;
}
article.background-image h1 {
position: absolute;
margin: 30% 0 0 10%;
font-size: 5rem;
color: var(--textColorWhite);
font-family: var(--titleFont);
}

article.background-image p {
position: absolute;
margin: 42% 0 0 10%;
font-size: 1rem;
color: var(--textColorWhite);
font-family: var(--textFont);
}

section.top-tracks-section {
background-color: var(--bgColorDarkRed);
}
Expand All @@ -22,6 +45,7 @@ section.top-tracks-section ul li {
flex-direction: column;
align-items: center;
border-bottom: none;
cursor: auto;
}
section.top-tracks-section ul li img {
border-radius: 1rem;
Expand All @@ -39,4 +63,14 @@ section.top-tracks-section ul li p {
grid-column: span 3;
padding-bottom: 2rem;
}
article.background-image p {
margin: 58% 0 0 10%;
}
article.background-image {
height: 17rem;
max-height: 339px;
}
article.background-image h1 {
font-size: 2rem;
}
}
20 changes: 10 additions & 10 deletions client/src/pages/Artists/ArtistsDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,16 @@ function ArtistDetails() {
return (
<>
<section className="artist-details">
<h1>{artist.name}</h1>
{artist.images?.[0] && (
<img
src={artist.images[0].url}
alt={artist.name}
width="200"
height="200"
/>
)}
{artist.genres && <p>Genres : {artist.genres.join(", ")}</p>}
<article
className="background-image"
style={{
backgroundImage: artist.images?.[0]
? `url(${artist.images[0].url})`
: undefined,
}}
>
<h1>{artist.name}</h1>
</article>
</section>
<DisplayAlbums albums={albums} />
<DisplayTracks topTracks={topTracks} />
Expand Down