Add replaceWithList and regexReplaceWithList filter functions#3213
Merged
Add replaceWithList and regexReplaceWithList filter functions#3213
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds two new filter functions (replaceWithList and regexReplaceWithList) to the WinMerge filter engine, enabling list-based string and regex replacements from tab-separated files.
Changes:
- Introduces
ReplaceList.h/cppfor loading replacement rules from files - Adds
replaceWithListandregexReplaceWithListfunctions to the filter engine - Optimizes
regexreplaceby caching compiled regular expressions - Updates documentation across multiple languages
Reviewed changes
Copilot reviewed 10 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Src/FilterEngine/ReplaceList.h | New header declaring list loading functions |
| Src/FilterEngine/ReplaceList.cpp | Implementation of list loading with encoding detection |
| Src/FilterEngine/FilterExpressionNodes.cpp | New functions and optimization improvements |
| Testing/GoogleTest/FilterEngine/FilterExpression_test.cpp | Comprehensive unit tests for new features |
| Docs/Manual/English/Filters.xml | Documentation for new filter functions |
| Translations/Docs/Manual/*.po | Updated translation files |
Comments suppressed due to low confidence (2)
Src/FilterEngine/FilterExpressionNodes.cpp:1247
- The unused variable 'replacements' should be removed from the ReplaceFunc function, as it's declared but never used.
std::vector<std::pair<Poco::RegularExpression, std::string>> replacements;
Src/FilterEngine/ReplaceList.cpp:2
- The file header comment is incomplete. It should include a brief description of what this file does.
/**
*/
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds replaceWithList and regexReplaceWithList functions to the filter engine.