Open
Conversation
Member
Author
|
Finishing this PR depends on resolving #208. |
Blackhex
force-pushed
the
fix-mingw-build
branch
from
b8b6bbb to
3b14658
Compare
Blackhex
force-pushed
the
fix-mingw-build
branch
from
3b14658 to
4953291
Compare
Blackhex
force-pushed
the
main
branch
2 times, most recently
from
4c6da12 to
f0c3082
Compare
Blackhex
force-pushed
the
fix-mingw-build
branch
from
4953291 to
f95e6c5
Compare
Blackhex
force-pushed
the
fix-mingw-build
branch
from
f95e6c5 to
5c9187b
Compare
Blackhex
force-pushed
the
fix-mingw-build
branch
6 times, most recently
from
2d3ea19 to
04bf4f3
Compare
Blackhex
commented
Mar 21, 2025
| $ROOT_PATH/.github/scripts/toolchain/build-gcc.sh | ||
|
|
||
| if [[ "$PLATFORM" =~ (mingw|cygwin) ]]; then | ||
| if [[ "$PLATFORM" =~ mingw ]]; then |
Member
Author
There was a problem hiding this comment.
As discussed with MinGW community there is no use case for building entire MinGW with Cygwin toolchain, especially winpthread library is not compatible with Cygwin system headers. Only MinGW CRT is needed to build Cygwin GCC which is done in build-mingw-crt.sh.
Blackhex
force-pushed
the
fix-mingw-build
branch
2 times, most recently
from
1cea8c4 to
96b075d
Compare
Blackhex
commented
Mar 21, 2025
|
|
||
| case "$ARCH-$PLATFORM" in | ||
| x86_64-w64-mingw32) | ||
| LDFLAGS="$LDFLAGS -L$TOOLCHAIN_PATH/lib/gcc/$TARGET/lib" |
Member
Author
There was a problem hiding this comment.
I don't know why but without this, there is an issue that linker cannot find libgcc_s on x86_64-w64-mingw32. This is not the case for aarch64-w64-mingw32 when linking winpthreads.
Blackhex
commented
Mar 21, 2025
| description: 'MinGW branch to build' | ||
| required: false | ||
| default: 'woarm64' | ||
| default: 'fix-stage2-fakelib' |
Member
Author
There was a problem hiding this comment.
To be reverted before merge.
Blackhex
commented
Mar 21, 2025
| mingw_branch: | ||
| description: 'Mingw branch to build' | ||
| required: false | ||
| default: 'woarm64' |
Member
Author
There was a problem hiding this comment.
To be reverted before merge.
Blackhex
changed the title
Blackhex
force-pushed
the
fix-mingw-build
branch
from
96b075d to
180ba2e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue of missing rebuilds for all MinGW libraries by updating the default branch for MinGW builds and adjusting the build conditions to target the correct platform.
- Updated default branch values for the MinGW build in both advanced and main workflows
- Modified the conditional logic for triggering the MinGW build in the advanced workflow
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/advanced.yml | Updated default branch and build condition to trigger only on w64-mingw32 |
| .github/workflows/main.yml | Updated default branch for MinGW builds |
Files not reviewed (3)
- .github/scripts/build.sh: Language not supported
- .github/scripts/toolchain/build-mingw.sh: Language not supported
- .github/scripts/toolchain/install-cygwin-headers.sh: Language not supported
Comments suppressed due to low confidence (5)
.github/workflows/advanced.yml:21
- Verify that the new default branch 'fix-stage2-fakelib' is intentional and aligns with the repository’s branch naming scheme.
default: 'fix-stage2-fakelib'
.github/workflows/advanced.yml:78
- Ensure that updating the MINGW_BRANCH default to 'fix-stage2-fakelib' does not conflict with other configurations or tooling expectations.
MINGW_BRANCH: ${{ inputs.mingw_branch || 'fix-stage2-fakelib' }}
.github/workflows/advanced.yml:318
- Review the updated condition to ensure that limiting the MinGW build to matrix.platform 'w64-mingw32' is correct, as it replaces the previous exclusion of 'pc-linux-gnu'.
if: ${{ steps.cache-toolchain.outputs.cache-hit != 'true' && matrix.platform == 'w64-mingw32' }}
.github/workflows/main.yml:21
- Confirm that the new default branch 'fix-stage2-fakelib' for MinGW in this workflow is consistent with the intended build process.
default: 'fix-stage2-fakelib'
.github/workflows/main.yml:25
- Ensure that the change to update the MINGW_BRANCH default value to 'fix-stage2-fakelib' is aligned with the overall branch strategy used in the project.
MINGW_BRANCH: ${{ inputs.mingw_branch || 'fix-stage2-fakelib' }}
460a2fe to
b25d872
Compare
Blackhex
force-pushed
the
fix-mingw-build
branch
from
b25d872 to
a8c54d3
Compare
Blackhex
force-pushed
the
fix-mingw-build
branch
from
a8c54d3 to
a522336
Compare
Blackhex
force-pushed
the
fix-mingw-build
branch
from
a522336 to
d312593
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current .github/scripts/toolchain/build-mingw.sh actually do not re-build MinGW libraries, e.g.
libwinpthreads. Also, it seems that build of MinGW is not needed for Cygwin toolchain builds.