[refactor] #175-Enum 기업규모 클래스명 변경 및 text 필드 추가 #176
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes refactor the naming and type of the enterprise size field across the codebase. All instances of the field named "entSize" with type Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/main/java/com/wooribound/global/constant/EnterpriseSize.java (1)
1-14: Well-structured enum with descriptive text fieldThe new
EnterpriseSizeenum provides better naming than the previousEntSizeand includes a descriptive text field for each value, improving readability and UI display capabilities.However, consider adding a getter method for the text field to make it accessible, as the RequiredArgsConstructor alone doesn't expose the field:
public enum EnterpriseSize { STARTUP("스타트업"), SMALL("중소기업"), MEDIUM("중견기업"), LARGE("대기업"); private final String text; + + public String getText() { + return text; + } }src/main/java/com/wooribound/api/corporate/dto/EnterpiseJoinDTO.java (1)
30-31: Consider updating validation message for consistencyWhile the field has been renamed from
entSizetoenterpriseSize, the validation message still references the old field name "entSize". Consider updating the validation message to match the new field name for consistency.- @NotEmpty(message = "entSize 필드는 필수입니다.") + @NotEmpty(message = "enterpriseSize 필드는 필수입니다.") private EnterpriseSize enterpriseSize;src/main/java/com/wooribound/domain/enterprise/dto/EnterpriseDTO.java (1)
37-38: Update validation message to match the new field nameThe field has been renamed from
entSizetoenterpriseSize, but the validation error message still refers to the old field name. Consider updating the message to maintain consistency.- @NotEmpty(message = "entSize 필드는 필수입니다.") + @NotEmpty(message = "enterpriseSize 필드는 필수입니다.") private EnterpriseSize enterpriseSize;src/main/java/com/wooribound/domain/enterprise/EnterpriseServiceImpl.java (1)
103-103: Update string literal to match renamed fieldThe field has been renamed from
entSizetoenterpriseSize, but the string representation in the return statement still uses "EntSize". Update it to maintain consistency with the renamed field.- "EntSize : " + enterprise.getEnterpriseSize() + ", " + + "EnterpriseSize : " + enterprise.getEnterpriseSize() + ", " +
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
src/main/java/com/wooribound/api/corporate/dto/EnterpiseJoinDTO.java(2 hunks)src/main/java/com/wooribound/api/corporate/dto/EnterpriseInfoReqDTO.java(2 hunks)src/main/java/com/wooribound/api/corporate/facade/EnterpriseAuthFacade.java(1 hunks)src/main/java/com/wooribound/domain/enterprise/Enterprise.java(2 hunks)src/main/java/com/wooribound/domain/enterprise/EnterpriseServiceImpl.java(4 hunks)src/main/java/com/wooribound/domain/enterprise/dto/AdminEnterpriseDetailDTO.java(2 hunks)src/main/java/com/wooribound/domain/enterprise/dto/EnterpriseDTO.java(2 hunks)src/main/java/com/wooribound/domain/enterprise/dto/EnterpriseInfoDTO.java(2 hunks)src/main/java/com/wooribound/domain/enterprise/service/AdminEnterpriseServiceImpl.java(1 hunks)src/main/java/com/wooribound/global/constant/EntSize.java(0 hunks)src/main/java/com/wooribound/global/constant/EnterpriseSize.java(1 hunks)
💤 Files with no reviewable changes (1)
- src/main/java/com/wooribound/global/constant/EntSize.java
🧰 Additional context used
🧬 Code Definitions (1)
src/main/java/com/wooribound/global/constant/EnterpriseSize.java (1)
src/main/java/com/wooribound/domain/enterprise/service/AdminEnterpriseServiceImpl.java (1)
RequiredArgsConstructor(17-89)
🔇 Additional comments (11)
src/main/java/com/wooribound/domain/enterprise/service/AdminEnterpriseServiceImpl.java (1)
57-57: Field name change consistent with enum refactoringThe field reference has been properly updated from
entSizetoenterpriseSizeto reflect the enum class renaming. This change maintains consistency with the broader refactoring effort across the codebase.src/main/java/com/wooribound/api/corporate/dto/EnterpriseInfoReqDTO.java (2)
3-3: Updated import to new enum classThe import statement has been correctly updated to reference the new
EnterpriseSizeenum, aligning with the refactoring effort.
19-19: Field name and type updated consistentlyThe field has been appropriately renamed from
entSizetoenterpriseSizewith its type updated toEnterpriseSize, maintaining consistency with the enum refactoring.src/main/java/com/wooribound/domain/enterprise/dto/EnterpriseInfoDTO.java (2)
3-3: Updated import to new enum classThe import statement has been correctly updated to reference the new
EnterpriseSizeenum, aligning with the refactoring effort.
20-20: Field name and type updated consistentlyThe field has been appropriately renamed from
entSizetoenterpriseSizewith its type updated toEnterpriseSize, maintaining consistency with the enum refactoring.src/main/java/com/wooribound/api/corporate/facade/EnterpriseAuthFacade.java (1)
33-33: Field name properly updatedThe field name has been correctly updated from
getEntSize()togetEnterpriseSize()to match the new naming convention in the EnterpiseJoinDTO. This maintains consistency with the renamed enum type.src/main/java/com/wooribound/api/corporate/dto/EnterpiseJoinDTO.java (1)
3-3: Import correctly updatedThe import has been properly updated to use the new
EnterpriseSizeenum.src/main/java/com/wooribound/domain/enterprise/Enterprise.java (2)
4-4: Import correctly updatedThe import has been properly updated to use the new
EnterpriseSizeenum.
37-39: Field name and type updated correctlyThe field has been correctly renamed from
entSizetoenterpriseSizewhile the database column name remains asent_sizeto maintain backward compatibility. This is a good practice as it keeps the database schema unchanged while improving the code readability.src/main/java/com/wooribound/domain/enterprise/dto/AdminEnterpriseDetailDTO.java (2)
3-3: Import correctly updatedThe import has been properly updated to use the new
EnterpriseSizeenum.
20-20: Field type and name updated correctlyThe field has been correctly renamed from
entSizetoenterpriseSizeto be consistent with the related changes across the codebase.
soljjang777
changed the title
Summary by CodeRabbit