-
Notifications
You must be signed in to change notification settings - Fork 77
fix: Remove RpcEntryNotFound from ClioError #2661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: Remove RpcEntryNotFound from ClioError #2661
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2661 +/- ##
========================================
Coverage 81.91% 81.91%
========================================
Files 381 381
Lines 14424 14424
Branches 7936 7936
========================================
Hits 11816 11816
Misses 1443 1443
Partials 1165 1165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good, thanks! |
godexsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ![]()
Since rippled has its own error codes, all occurrences have been replaced except for PR2549, and the entry has also been removed entirely from Clio’s error enum. This modification follows the feedback provided in this comment: #2549 (comment)
Pending compatible libxrpl — temporarily on hold