feat: TEMP DRAFT: Convert CMake UNIT_TEST_REFERENCE_FEE to command line unittest-fee#5394
feat: TEMP DRAFT: Convert CMake UNIT_TEST_REFERENCE_FEE to command line unittest-fee#5394
Conversation
1e82440 to
01b152d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5394 +/- ##
=======================================
Coverage 78.7% 78.7%
=======================================
Files 816 816
Lines 72275 72285 +10
Branches 8542 8522 -20
=======================================
+ Hits 56872 56882 +10
Misses 15403 15403
🚀 New features to boost your workflow:
|
d6a2ce2 to
84b4e2a
Compare
84b4e2a to
98bafb2
Compare
- Takes a page from #5394, which may turn out to be useful!
98bafb2 to
be219fe
Compare
9ab36dd to
fb2eb35
Compare
8481ed6 to
7937823
Compare
40d80b8 to
01cc089
Compare
7937823 to
de0b4e1
Compare
de0b4e1 to
b17e50d
Compare
b17e50d to
4da5c72
Compare
fa2bbf1 to
ec11ae3
Compare
a9283e6 to
a9ccb6a
Compare
a4bd2ae to
3506237
Compare
b22b10c to
bfc3e3c
Compare
dd8a482 to
233ad4a
Compare
eb000af to
0466a9d
Compare
| run: | | ||
| ./xrpld --unittest --unittest-jobs "${BUILD_NPROC}" | ||
| ./xrpld --unittest --unittest-jobs "${BUILD_NPROC}" \ | ||
| ${{ inputs.unittest_args }} | ||
|
|
There was a problem hiding this comment.
Using variable interpolation ${{...}} with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".
🍰 Removed in commit 21315d6 🍰
| run: | | ||
| ./xrpld --unittest --unittest-jobs "${BUILD_NPROC}" | ||
| ./xrpld --unittest --unittest-jobs "${BUILD_NPROC}" \ | ||
| ${{ inputs.unittest_args }} | ||
|
|
There was a problem hiding this comment.
Using variable interpolation ${{...}} with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".
✨ Fixed in commit cdcc6b6 ✨
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
|
If only the most recent commit is unsigned, you can run:
If multiple commits are unsigned, you can run:
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
- Remove the cmake UNIT_TEST_REFERENCE_FEE setting - Replaced by --unittest-fee runtime param
|
Squashed and rebased to resolve unsigned commit issues. |
* XRPLF/develop: chore: Move codegen venv setup into build stage (6617)
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)