feat: add WASMI dependency #5999

mvadari · 2025-11-04T20:58:59Z

High Level Overview of Change

This PR adds Wasmi as a dependency to rippled, in preparation for Smart Escrows.

Context of Change

Splitting up #5600 into more managably reviewable chunks

XLS-102

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Performance (increase or change in throughput and/or latency)
Tests (you added tests for code that already exists, or your new feature included in this PR)
Documentation update
Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
Release

API Impact

N/A

Test Plan

CI passes and everything compiles in properly without error.

Future Tasks

Additional PRs for the rest of the Smart Escrow functionality

Bronek · 2025-11-07T16:08:16Z

@mvadari we would normally upload our custom recipes to https://github.com/XRPLF/conan-center-index

codecov · 2025-11-24T21:51:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.1%. Comparing base (53aa5ca) to head (bbc28b3).

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5999     +/-   ##
=========================================
- Coverage     79.1%   79.1%   -0.0%     
=========================================
  Files          836     836             
  Lines        71261   71261             
  Branches      8301    8303      +2     
=========================================
- Hits         56399   56393      -6     
- Misses       14862   14868      +6

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bthomee · 2025-11-24T22:46:03Z

.github/workflows/reusable-build-test-config.yml


      - name: Prepare runner
-        uses: XRPLF/actions/.github/actions/prepare-runner@99685816bb60a95a66852f212f382580e180df3a
+        uses: XRPLF/actions/.github/actions/prepare-runner@ff9f8f649df5855ffe1a1ae715df43e51807f2e0


Is this change here and in the other CI file still required? I suspect this is an older hash than what is currently used by the develop branch.

Copilot

Pull request overview

This PR adds WASMI (WebAssembly interpreter) version 0.42.1 as a dependency to rippled in preparation for the Smart Escrows feature (XLS-102). The integration includes custom patches to the upstream WASMI library, Conan package configuration, and updates to the build system and CI/CD pipelines.

Key Changes

Added WASMI 0.42.1 dependency with custom patches for C API modifications and build system integration
Integrated WASMI into the Conan build system with local recipe export workflow
Updated CI/CD Docker images (SHA: ca4517d) and build scripts to support WASMI compilation

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
external/wasmi/patches/0001-xrplf-0.42.1.patch	Custom patch for WASMI 0.42.1 adding fuel management APIs and build system modifications for static linking
external/wasmi/conanfile.py	Conan recipe for building WASMI from source with CMake integration
external/wasmi/conandata.yml	Conan data file specifying WASMI source URL, SHA256, and patch metadata
conanfile.py	Added wasmi/0.42.1 to project dependencies and package info
conan.lock	Removed lockfile (will be regenerated during build)
cmake/XrplCore.cmake	Added wasmi::wasmi to xrpl.imports.main link libraries
CMakeLists.txt	Added find_package(wasmi REQUIRED) to locate WASMI during configuration
BUILD.md	Added instructions for exporting WASMI Conan recipe locally
.github/workflows/upload-conan-deps.yml	Updated prepare-runner action reference to newer SHA
.github/workflows/reusable-build-test-config.yml	Updated prepare-runner action reference to newer SHA
.github/scripts/strategy-matrix/linux.json	Updated all Docker image SHAs to `ca4517d` for Linux build matrix
.github/actions/build-deps/action.yml	Added local wasmi export step before conan install

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-02T23:44:51Z

external/wasmi/patches/0001-xrplf-0.42.1.patch

+    store: &mut wasm_store_t,
+    fuel: u64,
+) -> Option<Box<wasmi_error_t>> {
+


Trailing whitespace on empty line. This should be removed to maintain code cleanliness.

Copilot · 2025-12-02T23:44:52Z

external/wasmi/patches/0001-xrplf-0.42.1.patch

+//WASM_API_EXTERN void *wasm_store_get_data(const wasm_store_t*);
+//WASM_API_EXTERN void wasm_store_set_data(wasm_store_t*, void *data);


Commented-out code should be removed rather than left in the codebase. If these functions are needed in the future, they can be retrieved from version control. If they're not intended to be used yet, consider removing them from the patch entirely.

Suggested change

+//WASM_API_EXTERN void *wasm_store_get_data(const wasm_store_t*);

+//WASM_API_EXTERN void wasm_store_set_data(wasm_store_t*, void *data);

Copilot · 2025-12-02T23:44:52Z

external/wasmi/patches/0001-xrplf-0.42.1.patch

+////////////////////////////////////////////////////////////////////////////////////////
+////////////////////////////////////////////////////////////////////////////////////////
+////////////////////////////////////////////////////////////////////////////////////////


[nitpick] Excessive visual separator comment lines (4 lines of forward slashes). This adds clutter without providing value. Consider reducing to a single line separator or using a more conventional Rust doc comment style.

Suggested change

+////////////////////////////////////////////////////////////////////////////////////////

+////////////////////////////////////////////////////////////////////////////////////////

+////////////////////////////////////////////////////////////////////////////////////////

Copilot · 2025-12-02T23:44:53Z

.github/actions/build-deps/action.yml

        LOG_VERBOSITY: ${{ inputs.log_verbosity }}
      run: |
        echo 'Installing dependencies.'
+        conan export --version 0.42.1 external/wasmi  #TODO Switch to conan package


[nitpick] The TODO comment suggests this is a temporary workaround. Consider creating a GitHub issue to track the work needed to switch to a conan package instead of relying on local export, and reference it in the comment (e.g., #TODO: Switch to conan package (issue #XXXX)).

Suggested change

conan export --version 0.42.1 external/wasmi #TODO Switch to conan package

conan export --version 0.42.1 external/wasmi #TODO: Switch to conan package (issue #1234)

Copilot · 2025-12-02T23:44:53Z

external/wasmi/conanfile.py

@@ -0,0 +1,48 @@
+from conan import ConanFile, tools


Unused import: tools is imported from conan but never used in this file. This should be removed to keep the imports clean.

Suggested change

from conan import ConanFile, tools

from conan import ConanFile

Copilot · 2025-12-02T23:44:53Z

external/wasmi/conanfile.py

+        self.cpp_info.names["cmake_find_package"] = "wasmi"
+        self.cpp_info.names["cmake_find_package_multi"] = "wasmi"


The cpp_info.names attributes (cmake_find_package and cmake_find_package_multi) are deprecated in Conan 2.0 and should not be used. These attributes were for Conan 1.x compatibility. Since this recipe specifies required_conan_version = ">=2.0.0", these lines should be removed. Conan 2.0 uses the package name directly.

Suggested change

self.cpp_info.names["cmake_find_package"] = "wasmi"

self.cpp_info.names["cmake_find_package_multi"] = "wasmi"

Copilot · 2025-12-02T23:44:53Z

BUILD.md

+conan export --version 0.42.1 external/wasmi
 rm -rf .git
 ```



Incorrect path for conan export. The instruction should be conan export --version 0.42.1 external/wasmi but it's located in a section where other exports use paths like recipes/ed25519/all. This instruction appears in the wrong location - it's shown after checking out recipes from the conan-center-index repository, but external/wasmi is part of the rippled repository itself, not the conan-center-index. This line should be moved outside the git sparse-checkout section, or the section should be clarified to indicate when to run this command.

Suggested change

conan export --version 0.42.1 external/wasmi

rm -rf .git

```

rm -rf .git

Exporting the local wasmi recipe

The wasmi recipe is part of the rippled repository itself, not the conan-center-index. To export it, run:

conan export --version 0.42.1 external/wasmi

* Use conan repo for wasmi lib * Generate lockfile

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vvysokikh1 · 2026-01-07T11:17:09Z

Could you please resolve the conflict?

mvadari · 2026-01-07T19:35:24Z

Could you please resolve the conflict?

@vvysokikh1 done

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/upload-conan-deps.yml

.github/workflows/reusable-build-test-config.yml

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bthomee

This looks good. I'll hold off with approving until the Conan recipe has been updated to use the newly created wasmi fork.

WASMI data

0db564d

Bronek requested a review from vvysokikh1 November 7, 2025 16:06

mvadari added 4 commits November 25, 2025 02:31

update

35f7cbf

Merge branch 'develop' into ripple/wasmi

ce9f0b3

remove conan.lock (temporary)

25c3060

fix merge issue

16087c9

Fix win build (#6076)

500bb68

bthomee reviewed Nov 24, 2025

View reviewed changes

This was referenced Dec 2, 2025

feat: add WASM host functions (Wasmi version) #6075

Open

feat: add WAMR dependency #5790

Closed

feat: XLS-100 Smart Escrows #6003

Open

Merge branch 'develop' into ripple/wasmi

6d26408

Copilot AI review requested due to automatic review settings December 2, 2025 23:41

Copilot started reviewing on behalf of mvadari December 2, 2025 23:41 View session

Copilot finished reviewing on behalf of mvadari December 2, 2025 23:43

Copilot AI reviewed Dec 2, 2025

View reviewed changes

mvadari and others added 2 commits December 5, 2025 14:32

Merge branch 'develop' into ripple/wasmi

8a403f1

Use conan repo for wasmi lib (#6109)

b57df29

* Use conan repo for wasmi lib * Generate lockfile

Copilot AI review requested due to automatic review settings December 8, 2025 18:02

Copilot AI reviewed Dec 8, 2025

View reviewed changes

Merge branch 'develop' into ripple/wasmi

90e0bbd

mvadari requested a review from Copilot December 8, 2025 19:44

Copilot started reviewing on behalf of mvadari December 8, 2025 19:44 View session

Copilot AI reviewed Dec 8, 2025

View reviewed changes

sappenin mentioned this pull request Dec 17, 2025

Update rippled branch target once Smart Escrow are merged ripple/xrpl-wasm-stdlib#120

Open

mvadari added 2 commits December 22, 2025 15:51

Merge remote-tracking branch 'upstream/develop' into ripple/wasmi

6c95548

Merge remote-tracking branch 'upstream/develop' into ripple/wasmi

1977df9

Merge branch 'develop' into ripple/wasmi

8ea5106

Copilot AI review requested due to automatic review settings January 7, 2026 19:35

Copilot started reviewing on behalf of mvadari January 7, 2026 19:35 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

.github/workflows/upload-conan-deps.yml Outdated Show resolved Hide resolved

.github/workflows/reusable-build-test-config.yml Outdated Show resolved Hide resolved

mvadari and others added 2 commits January 7, 2026 16:50

use the develop hashes

2c30e41

Merge branch 'develop' into ripple/wasmi

5aab274

Copilot AI review requested due to automatic review settings January 7, 2026 21:52

Copilot started reviewing on behalf of mvadari January 7, 2026 21:52 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Merge branch 'develop' into ripple/wasmi

bbc28b3

bthomee reviewed Jan 8, 2026

View reviewed changes

		+//WASM_API_EXTERN void wasm_store_get_data(const wasm_store_t);
		+//WASM_API_EXTERN void wasm_store_set_data(wasm_store_t, void data);

	+////////////////////////////////////////////////////////////////////////////////////////
	+////////////////////////////////////////////////////////////////////////////////////////
	+////////////////////////////////////////////////////////////////////////////////////////

	conan export --version 0.42.1 external/wasmi #TODO Switch to conan package
	conan export --version 0.42.1 external/wasmi #TODO: Switch to conan package (issue #1234)

	from conan import ConanFile, tools
	from conan import ConanFile

		self.cpp_info.names["cmake_find_package"] = "wasmi"
		self.cpp_info.names["cmake_find_package_multi"] = "wasmi"

feat: add WASMI dependency #5999

Are you sure you want to change the base?

feat: add WASMI dependency #5999

Conversation

mvadari commented Nov 4, 2025

High Level Overview of Change

Context of Change

Type of Change

API Impact

Test Plan

Future Tasks

Uh oh!

Bronek commented Nov 7, 2025

Uh oh!

codecov bot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bthomee Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

mvadari Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Exporting the local wasmi recipe

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

vvysokikh1 commented Jan 7, 2026

Uh oh!

mvadari commented Jan 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

bthomee left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

codecov bot commented Nov 24, 2025 •

edited

Loading