Closed
Conversation
- Update the conversion points between Number and *Amount & STNumber. - Tests probably don't pass.
- Track down and fix edge cases. - Some refactoring and renaming for clarity and simplicity
- Field will be absent in RPC results instead of returning 0.
…number-simple * upstream/develop: chore: Clean up incorrect comments (6031) refactor: Retire MultiSignReserve and ExpandedSignerList amendments (5981)
- Update tests. Unfinished. - TODO: Finish Number tests. Use both modes for STNumber tests. Move mantissa_scale into MantissaRange.
- Fix cross-compiler build issues
- Nothing really needed to be changed in the tests, but I added a couple of test cases for the min and max int64.
- Added test cases min int64. - Updated numberFromJson range checking to use the larger range available from Number.
- Default Number outside of transaction processing to be "large" so RPC will work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Code was originally in branch
ximinez/lending-number-simple, #6025High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)