Skip to content

Fix traces#6127

Merged
oleks-rip merged 10 commits intoXRPLF:ripple/wasmi-host-functionsfrom
oleks-rip:trace_fix
Jan 13, 2026
Merged

Fix traces#6127
oleks-rip merged 10 commits intoXRPLF:ripple/wasmi-host-functionsfrom
oleks-rip:trace_fix

Conversation

@oleks-rip
Copy link
Collaborator

High Level Overview of Change

Don't do anything if severity level lower then trace

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@oleks-rip oleks-rip requested review from mvadari and pwang200 December 8, 2025 21:35
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.6%. Comparing base (1c812a6) to head (4f1b713).
⚠️ Report is 1 commits behind head on ripple/wasmi-host-functions.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           ripple/wasmi-host-functions   #6127   +/-   ##
===========================================================
  Coverage                         79.6%   79.6%           
===========================================================
  Files                              846     846           
  Lines                            73404   73420   +16     
  Branches                          8359    8359           
===========================================================
+ Hits                             58458   58475   +17     
+ Misses                           14946   14945    -1     
Files with missing lines Coverage Δ
src/xrpld/app/wasm/detail/HostFuncImpl.cpp 100.0% <100.0%> (ø)
src/xrpld/app/wasm/detail/WasmiVM.cpp 93.2% <100.0%> (+<0.1%) ⬆️

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tHiSiShEaTh
Copy link

Codecov Report

❌ Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review. ✅ Project coverage is 79.5%. Comparing base (881087d) to head (77d40cd).

Files with missing lines Patch % Lines
src/xrpld/app/wasm/detail/HostFuncImpl.cpp 50.0% 5 Missing ⚠️
Additional details and impacted files
🚀 New features to boost your workflow:

S. N.

@oleks-rip oleks-rip force-pushed the trace_fix branch 2 times, most recently from bfc4f31 to c39cc57 Compare January 6, 2026 00:14
@oleks-rip oleks-rip requested a review from mvadari January 6, 2026 00:35
"get_parent_ledger_hash_len_too_long",
)
});
let message = "testing trace";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are duplicates?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, from line 241

@oleks-rip oleks-rip force-pushed the trace_fix branch 2 times, most recently from 0429f85 to 7027819 Compare January 13, 2026 00:16
@oleks-rip oleks-rip merged commit 81cbc91 into XRPLF:ripple/wasmi-host-functions Jan 13, 2026
25 checks passed
@oleks-rip oleks-rip deleted the trace_fix branch January 13, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants