Skip to content

Conversation

@mvadari
Copy link
Collaborator

@mvadari mvadari commented Jan 7, 2026

High Level Overview of Change

This PR removes HashPrefix::credential, which is not used anywhere.

Context of Change

Drive-by fix

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

N/A

Test Plan

CI passes.

Removed credentials signature hash prefix from HashPrefix.h
@mvadari mvadari requested a review from a team as a code owner January 7, 2026 23:21
Copilot AI review requested due to automatic review settings January 7, 2026 23:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused HashPrefix::credential enum value from the HashPrefix enumeration. This is a simple cleanup that removes dead code with no functional impact.

  • Removes the HashPrefix::credential enum value that was defined but never used in the codebase

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mvadari mvadari requested a review from bthomee January 7, 2026 23:33
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.1%. Comparing base (07ff532) to head (0df6846).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6186   +/-   ##
=======================================
  Coverage     79.1%   79.1%           
=======================================
  Files          836     836           
  Lines        71260   71260           
  Branches      8306    8299    -7     
=======================================
+ Hits         56392   56396    +4     
+ Misses       14868   14864    -4     
Files with missing lines Coverage Δ
include/xrpl/protocol/HashPrefix.h 100.0% <ø> (ø)

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee bthomee merged commit 17565d2 into develop Jan 8, 2026
32 checks passed
@bthomee bthomee deleted the mvadari/remove-cred-prefix branch January 8, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants