Skip to content

Conversation

@mvadari
Copy link
Collaborator

@mvadari mvadari commented Jan 9, 2026

High Level Overview of Change

This PR fixes a typo in LCOV flags. No source code change.

Context of Change

In Actions:
image

Type of Change

  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Test Plan

The warning no longer shows up in CI.

Copilot AI review requested due to automatic review settings January 9, 2026 15:19
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Jan 9, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a typo in LCOV (code coverage tool) exclusion markers. The issue was that line 70 in LoanBrokerDelete.cpp incorrectly had LCOV_EXCL_START when it should have been LCOV_EXCL_STOP to properly close the exclusion block that started on line 66.

  • Fixed mismatched LCOV exclusion marker pair (START/START → START/STOP)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.1%. Comparing base (e1d97be) to head (689f77d).
⚠️ Report is 12 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6196   +/-   ##
=======================================
  Coverage     79.1%   79.1%           
=======================================
  Files          836     836           
  Lines        71261   71249   -12     
  Branches      8305    8301    -4     
=======================================
- Hits         56394   56393    -1     
+ Misses       14867   14856   -11     
Files with missing lines Coverage Δ
src/xrpld/app/tx/detail/LoanBrokerDelete.cpp 83.5% <ø> (+11.0%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari requested a review from bthomee January 9, 2026 16:44
@bthomee
Copy link
Collaborator

bthomee commented Jan 9, 2026

I believe these fixes have been made in the lending branch, which should get merged today.

@mvadari
Copy link
Collaborator Author

mvadari commented Jan 9, 2026

I believe these fixes have been made in the lending branch, which should get merged today.

Ok, great. Will wait to close until that's confirmed.

@mvadari
Copy link
Collaborator Author

mvadari commented Jan 13, 2026

Looks like this was fixed in #6102, closing

@mvadari mvadari closed this Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants