adds sfData field to VaultDelete transaction#6356
Open
Tapanito wants to merge 7 commits intotapanito/lending-fix-amendmentfrom
Open
adds sfData field to VaultDelete transaction#6356Tapanito wants to merge 7 commits intotapanito/lending-fix-amendmentfrom
Tapanito wants to merge 7 commits intotapanito/lending-fix-amendmentfrom
Conversation
df4e319 to
f8b555d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## tapanito/lending-fix-amendment #6356 +/- ##
================================================================
- Coverage 79.9% 79.9% -0.0%
================================================================
Files 842 842
Lines 65553 65557 +4
Branches 7250 7253 +3
================================================================
+ Hits 52394 52396 +2
- Misses 13159 13161 +2
🚀 New features to boost your workflow:
|
mvadari
reviewed
Feb 12, 2026
mvadari
reviewed
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
Datafield to theVaultDeletetransaction to register the reason for deletion.Specification: XRPLF/XRPL-Standards#470
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)