Skip to content

adds sfData field to VaultDelete transaction#6356

Open
Tapanito wants to merge 7 commits intotapanito/lending-fix-amendmentfrom
tapanito/vault-delete-data
Open

adds sfData field to VaultDelete transaction#6356
Tapanito wants to merge 7 commits intotapanito/lending-fix-amendmentfrom
tapanito/vault-delete-data

Conversation

@Tapanito
Copy link
Collaborator

@Tapanito Tapanito commented Feb 12, 2026

This PR adds an optional Data field to the VaultDelete transaction to register the reason for deletion.

Specification: XRPLF/XRPL-Standards#470

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@Tapanito Tapanito force-pushed the tapanito/vault-delete-data branch from df4e319 to f8b555d Compare February 12, 2026 10:47
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.9%. Comparing base (74c968d) to head (667b559).

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           tapanito/lending-fix-amendment   #6356     +/-   ##
================================================================
- Coverage                            79.9%   79.9%   -0.0%     
================================================================
  Files                                 842     842             
  Lines                               65553   65557      +4     
  Branches                             7250    7253      +3     
================================================================
+ Hits                                52394   52396      +2     
- Misses                              13159   13161      +2     
Files with missing lines Coverage Δ
include/xrpl/protocol/detail/transactions.macro 100.0% <ø> (ø)
src/xrpld/app/tx/detail/VaultDelete.cpp 91.8% <100.0%> (+0.6%) ⬆️

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments