Disable reusing wasm module#6364
Disable reusing wasm module#6364oleks-rip wants to merge 5 commits intoXRPLF:ripple/wasmi-host-functionsfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## ripple/wasmi-host-functions #6364 +/- ##
=============================================================
- Coverage 80.5% 80.5% -0.0%
=============================================================
Files 861 861
Lines 67751 67702 -49
Branches 7285 7286 +1
=============================================================
- Hits 54544 54490 -54
- Misses 13207 13212 +5
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
|
||
| virtual Expected<std::uint32_t, HostFunctionError> | ||
| getLedgerSqn() | ||
| getLedgerSqn() const |
There was a problem hiding this comment.
Why are these functions all changing to const?
There was a problem hiding this comment.
Because they can
There was a problem hiding this comment.
For next time, it would make the PR easier to read if the const changes were in their own PR (maybe a follow-up).
oleks-rip
force-pushed
the
one_inst
branch
2 times, most recently
from
f5dbc0e to
e2f88c9
Compare
|
|
||
| extern std::string const allHostFunctionsWasmHex; | ||
|
|
||
| extern std::string const deepRecursionHex; |
There was a problem hiding this comment.
Why are so many tests removed here? They're not all perf tests
There was a problem hiding this comment.
recursion moved to loop tests, other tests using vector in parameters, which is disabled now, float tests grouped with float
There was a problem hiding this comment.
Do the loop tests check recursion? Don't they just check loops?
There was a problem hiding this comment.
recursion is another kind of a loop, so just group them for better perception
There was a problem hiding this comment.
Are you sure? There doesn't seem to be another recursion stack overflow test. Same with badAlloc
There was a problem hiding this comment.
Recursion can stop on 2 conditions: 1) gas finished - just like infinity loop; 2) stack finished. So ye, they are similar.
Bad alloc is impossible now, so it was removed. And bad alloc test has nothing in common with recursion or loop.
3 participants
High Level Overview of Change
Reusing module functionality left only for performance testing and will not be available in release.
Type of Change
.gitignore, formatting, dropping support for older tooling)