Skip to content

Number scale helper function#6384

Draft
ximinez wants to merge 2 commits intotapanito/lending-vault-invariantfrom
ximinez/number-scale2
Draft

Number scale helper function#6384
ximinez wants to merge 2 commits intotapanito/lending-vault-invariantfrom
ximinez/number-scale2

Conversation

@ximinez
Copy link
Collaborator

@ximinez ximinez commented Feb 18, 2026

High Level Overview of Change

After looking again at #6246 changes, I realized there could be a simpler function call.

Context of Change

Type of Change

  • Refactor (non-breaking change that only restructures code)

@ximinez ximinez changed the title attempt to fix rounding issues Number scale helper function Feb 18, 2026
@ximinez ximinez changed the base branch from tapanito/lending-fix-amendment to tapanito/lending-vault-invariant February 18, 2026 19:58
@ximinez ximinez added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Feb 18, 2026
@ximinez ximinez marked this pull request as ready for review February 18, 2026 19:59
@ximinez ximinez marked this pull request as draft February 18, 2026 19:59
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.9%. Comparing base (a6b7d4e) to head (c90a3f9).

Files with missing lines Patch % Lines
src/xrpld/app/tx/detail/InvariantCheck.cpp 50.0% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           tapanito/lending-vault-invariant   #6384   +/-   ##
================================================================
  Coverage                              79.9%   79.9%           
================================================================
  Files                                   842     842           
  Lines                                 65625   65627    +2     
  Branches                               7253    7253           
================================================================
+ Hits                                  52457   52459    +2     
  Misses                                13168   13168           
Files with missing lines Coverage Δ
include/xrpl/protocol/STAmount.h 95.6% <100.0%> (+0.1%) ⬆️
src/xrpld/app/misc/LendingHelpers.h 94.7% <100.0%> (ø)
...rc/xrpld/app/tx/detail/LoanBrokerCoverWithdraw.cpp 96.3% <100.0%> (ø)
src/xrpld/app/tx/detail/InvariantCheck.cpp 92.8% <50.0%> (ø)

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DraftRunCI Normally CI does not run on draft PRs. This opts in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments