Skip to content

fix clang-tidy

ea3ca12
Select commit
Loading
Failed to load commit list.
Open

refactor: Start making ledger helpers type-safe, beginning with AccountRoot #6620

fix clang-tidy
ea3ca12
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 9, 2026 in 0s

81.6% (target 75.0%)

View this Pull Request on Codecov

81.6% (target 75.0%)

Details

Codecov Report

❌ Patch coverage is 97.05357% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.6%. Comparing base (56c9d1d) to head (ea3ca12).

Files with missing lines Patch % Lines
.../libxrpl/tx/transactors/lending/LendingHelpers.cpp 66.7% 8 Missing ⚠️
include/xrpl/ledger/helpers/AccountRootHelpers.h 65.0% 7 Missing ⚠️
include/xrpl/ledger/helpers/SLEBase.h 91.8% 5 Missing ⚠️
src/xrpld/rpc/handlers/account/AccountInfo.cpp 68.8% 5 Missing ⚠️
include/xrpl/ledger/helpers/EscrowHelpers.h 83.3% 2 Missing ⚠️
src/libxrpl/ledger/helpers/RippleStateHelpers.cpp 95.3% 2 Missing ⚠️
src/libxrpl/ledger/helpers/TokenHelpers.cpp 97.3% 1 Missing ⚠️
...c/libxrpl/tx/transactors/account/AccountDelete.cpp 95.5% 1 Missing ⚠️
src/libxrpl/tx/transactors/account/AccountSet.cpp 96.6% 1 Missing ⚠️
src/libxrpl/tx/transactors/dex/AMMClawback.cpp 87.5% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6620     +/-   ##
=========================================
- Coverage     81.6%   81.6%   -0.0%     
=========================================
  Files         1010    1011      +1     
  Lines        75982   76090    +108     
  Branches      7633    7640      +7     
=========================================
+ Hits         61983   62071     +88     
- Misses       13999   14019     +20     
Files with missing lines Coverage Δ
include/xrpl/ledger/View.h 100.0% <ø> (ø)
include/xrpl/ledger/helpers/RippleStateHelpers.h 100.0% <ø> (ø)
include/xrpl/tx/Transactor.h 100.0% <ø> (ø)
include/xrpl/tx/paths/detail/StepChecks.h 100.0% <100.0%> (ø)
...clude/xrpl/tx/transactors/lending/LendingHelpers.h 95.2% <ø> (ø)
src/libxrpl/ledger/View.cpp 96.6% <100.0%> (ø)
src/libxrpl/ledger/helpers/AMMHelpers.cpp 95.3% <100.0%> (ø)
src/libxrpl/ledger/helpers/AccountRootHelpers.cpp 96.0% <100.0%> (+0.9%) ⬆️
src/libxrpl/ledger/helpers/CredentialHelpers.cpp 97.6% <100.0%> (ø)
src/libxrpl/ledger/helpers/MPTokenHelpers.cpp 96.1% <100.0%> (ø)
... and 88 more

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.