Skip to content

chore: Enable clang-tidy modernize checks#6975

Merged
bthomee merged 12 commits intoXRPLF:developfrom
godexsoft:chore/clang-tidy-modernize
Apr 21, 2026
Merged

chore: Enable clang-tidy modernize checks#6975
bthomee merged 12 commits intoXRPLF:developfrom
godexsoft:chore/clang-tidy-modernize

Conversation

@godexsoft
Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR enables clang-tidy modernize-* checks.

API Impact

No impact.

@godexsoft godexsoft self-assigned this Apr 20, 2026
@godexsoft godexsoft added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Apr 20, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 86.23188% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.8%. Comparing base (ab887f5) to head (a7a0886).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/libxrpl/beast/insight/StatsDCollector.cpp 0.0% 13 Missing ⚠️
src/libxrpl/shamap/SHAMapDelta.cpp 66.7% 8 Missing ⚠️
include/xrpl/protocol/detail/token_errors.h 0.0% 2 Missing ⚠️
include/xrpl/shamap/SHAMapTxLeafNode.h 60.0% 2 Missing ⚠️
src/libxrpl/protocol/XChainAttestations.cpp 0.0% 2 Missing ⚠️
src/libxrpl/shamap/SHAMapSync.cpp 75.0% 2 Missing ⚠️
include/xrpl/basics/BasicConfig.h 50.0% 1 Missing ⚠️
include/xrpl/shamap/SHAMapTxPlusMetaLeafNode.h 66.7% 1 Missing ⚠️
src/libxrpl/beast/utility/beast_PropertyStream.cpp 50.0% 1 Missing ⚠️
src/libxrpl/json/json_value.cpp 50.0% 1 Missing ⚠️
... and 5 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6975     +/-   ##
=========================================
- Coverage     81.8%   81.8%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        76162   76140     -22     
  Branches      7529    7527      -2     
=========================================
- Hits         62303   62282     -21     
+ Misses       13859   13858      -1     
Files with missing lines Coverage Δ
include/xrpl/basics/CompressionAlgorithms.h 0.0% <ø> (ø)
include/xrpl/basics/Expected.h 100.0% <ø> (ø)
include/xrpl/basics/LocalValue.h 100.0% <100.0%> (ø)
include/xrpl/basics/Log.h 71.4% <ø> (ø)
include/xrpl/basics/SlabAllocator.h 93.2% <100.0%> (-0.2%) ⬇️
include/xrpl/basics/Slice.h 96.8% <ø> (ø)
include/xrpl/basics/TaggedCache.h 100.0% <ø> (ø)
include/xrpl/basics/ToString.h 100.0% <ø> (ø)
include/xrpl/basics/base_uint.h 94.3% <ø> (ø)
include/xrpl/basics/contract.h 87.5% <ø> (ø)
... and 192 more

... and 80 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godexsoft godexsoft removed the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Apr 20, 2026
@godexsoft godexsoft marked this pull request as ready for review April 20, 2026 15:18
@godexsoft godexsoft requested a review from kuznetsss April 20, 2026 15:21
Comment thread include/xrpl/server/detail/BaseHTTPPeer.h Outdated
Comment thread src/libxrpl/json/Writer.cpp Outdated
Comment thread include/xrpl/beast/container/detail/aged_ordered_container.h Outdated
@godexsoft godexsoft requested review from bthomee and kuznetsss April 20, 2026 16:33
Copy link
Copy Markdown
Contributor

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kuznetsss kuznetsss added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Apr 20, 2026
@bthomee bthomee added this pull request to the merge queue Apr 20, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 20, 2026
@bthomee bthomee added this pull request to the merge queue Apr 21, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 21, 2026
@bthomee bthomee enabled auto-merge April 21, 2026 15:05
@bthomee bthomee added this pull request to the merge queue Apr 21, 2026
Merged via the queue into XRPLF:develop with commit ce3951b Apr 21, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants