Skip to content

refactor: Remove seq from TMGetObjectByHash #6976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a1q123456 wants to merge 3 commits into
base: develop
Choose a base branch
from
+3 −10
Open

refactor: Remove seq from TMGetObjectByHash #6976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00632c6
Remove seq from TMGetObjectByHash as it's not needed
a1q123456 Apr 20, 2026
486a3a5
Mark the field as reserved to prevent future bugs
a1q123456 Apr 20, 2026
61ce265
Address comments
a1q123456 Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion include/xrpl/proto/xrpl.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,11 @@ message TMGetObjectByHash {
otTRANSACTIONS = 7;
}

// Previously used - don't reuse.
reserved 3;

required ObjectType type = 1;
required bool query = 2; // is this a query or a reply?
optional uint32 seq = 3; // used to match replies to queries
optional bytes ledgerHash = 4; // the hash of the ledger these queries are for
Comment thread
a1q123456 marked this conversation as resolved.
optional bool fat = 5; // return related nodes
repeated TMIndexedObject objects = 6; // the specific objects requested
Comment thread
a1q123456 marked this conversation as resolved.
Expand Down
1 change: 0 additions & 1 deletion src/test/overlay/compression_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ class compression_test : public beast::unit_test::suite
getObject->set_type(
protocol::TMGetObjectByHash_ObjectType::TMGetObjectByHash_ObjectType_otTRANSACTION);
getObject->set_query(true);
getObject->set_seq(123456789);
uint256 hash(xrpl::sha512Half(123456789));
getObject->set_ledgerhash(hash.data(), hash.size());
getObject->set_fat(true);
Expand Down
3 changes: 0 additions & 3 deletions src/xrpld/app/ledger/detail/LedgerMaster.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2113,9 +2113,6 @@ LedgerMaster::makeFetchPack(
protocol::TMGetObjectByHash reply;
reply.set_query(false);

if (request->has_seq())
reply.set_seq(request->seq());

reply.set_ledgerhash(request->ledgerhash());
reply.set_type(protocol::TMGetObjectByHash::otFETCH_PACK);

Expand Down
5 changes: 0 additions & 5 deletions src/xrpld/overlay/detail/PeerImp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2596,9 +2596,6 @@ PeerImp::onMessage(std::shared_ptr<protocol::TMGetObjectByHash> const& m)

reply.set_query(false);

if (packet.has_seq())
reply.set_seq(packet.seq());

reply.set_type(packet.type());

if (packet.has_ledgerhash())
Expand Down Expand Up @@ -2636,8 +2633,6 @@ PeerImp::onMessage(std::shared_ptr<protocol::TMGetObjectByHash> const& m)
if (obj.has_ledgerseq())
newObj.set_ledgerseq(obj.ledgerseq());

// VFALCO NOTE "seq" in the message is obsolete

// Check if by adding this object, reply has reached its
// limit
if (reply.objects_size() >= Tuning::hardMaxReplyNodes)
Expand Down
Loading