fix: Remaining clang-tidy unchecked optionals#6979
Draft
godexsoft wants to merge 1 commit intoXRPLF:developfrom
Draft
fix: Remaining clang-tidy unchecked optionals#6979godexsoft wants to merge 1 commit intoXRPLF:developfrom
godexsoft wants to merge 1 commit intoXRPLF:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6979 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 1010 1010
Lines 76162 76171 +9
Branches 7529 7526 -3
=======================================
+ Hits 62307 62317 +10
+ Misses 13855 13854 -1
🚀 New features to boost your workflow:
|
9185926 to
b8fe16f
Compare
|
If only the most recent commit is unsigned, you can run:
If multiple commits are unsigned, you can run:
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
Fix level More clang-tidy fixes Fix more from ci Autofixes on linux Fix format Bring back original shell Fix remaining clang-tidy More
16005c0 to
3303daf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR fixes remaining issues from
bugprone-unchecked-optional-access.API Impact
No impact.