Skip to content

fix: Remaining clang-tidy unchecked optionals#6979

Draft
godexsoft wants to merge 1 commit intoXRPLF:developfrom
godexsoft:fix/clang-tidy-optional
Draft

fix: Remaining clang-tidy unchecked optionals#6979
godexsoft wants to merge 1 commit intoXRPLF:developfrom
godexsoft:fix/clang-tidy-optional

Conversation

@godexsoft
Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR fixes remaining issues from bugprone-unchecked-optional-access.

API Impact

No impact.

@godexsoft godexsoft self-assigned this Apr 20, 2026
@godexsoft godexsoft added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Apr 20, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 87.23404% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.8%. Comparing base (ea02312) to head (cd33aae).

Files with missing lines Patch % Lines
include/xrpl/protocol/PublicKey.h 0.0% 3 Missing ⚠️
src/libxrpl/tx/paths/OfferStream.cpp 50.0% 1 Missing ⚠️
src/xrpld/consensus/LedgerTrie.h 0.0% 1 Missing ⚠️
src/xrpld/rpc/detail/PathRequest.cpp 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6979   +/-   ##
=======================================
  Coverage     81.8%   81.8%           
=======================================
  Files         1010    1010           
  Lines        76162   76171    +9     
  Branches      7529    7526    -3     
=======================================
+ Hits         62307   62317   +10     
+ Misses       13855   13854    -1     
Files with missing lines Coverage Δ
include/xrpl/tx/ApplyContext.h 100.0% <100.0%> (ø)
include/xrpl/tx/paths/OfferStream.h 100.0% <100.0%> (ø)
include/xrpl/tx/paths/detail/StrandFlow.h 93.2% <ø> (ø)
src/libxrpl/net/HTTPClient.cpp 70.9% <100.0%> (ø)
src/libxrpl/server/Manifest.cpp 85.7% <100.0%> (+0.2%) ⬆️
src/libxrpl/shamap/SHAMapInnerNode.cpp 96.5% <100.0%> (ø)
src/libxrpl/tx/ApplyContext.cpp 100.0% <100.0%> (ø)
src/libxrpl/tx/invariants/AMMInvariant.cpp 95.1% <ø> (ø)
src/libxrpl/tx/paths/BookStep.cpp 95.9% <100.0%> (+<0.1%) ⬆️
src/libxrpl/tx/paths/DirectStep.cpp 83.9% <ø> (ø)
... and 20 more

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godexsoft godexsoft force-pushed the fix/clang-tidy-optional branch from 9185926 to b8fe16f Compare April 20, 2026 17:28
@github-actions
Copy link
Copy Markdown

⚠️ This PR contains unsigned commits. To get your PR merged, please sign them. ⚠️

If only the most recent commit is unsigned, you can run:

  1. Amend the commit: git commit --amend --no-edit -n -S
  2. Overwrite the commit: git push --force-with-lease

If multiple commits are unsigned, you can run:

  1. Go into interactive rebase mode: git rebase --interactive HEAD~<NUM_OF_COMMITS>, where NUM_OF_COMMITS is the number of most recent commits that will be available to edit.
  2. Change "pick" to "edit" for the commits you need to sign, and then save and exit.
  3. For each commit, run: git commit --amend --no-edit -n -S
  4. Continue the rebase: git rebase --continue
  5. Overwrite the commit(s): git push --force-with-lease

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.
See use 1Password to sign your commits.

Fix level

More clang-tidy fixes

Fix more from ci

Autofixes on linux

Fix format

Bring back original shell

Fix remaining clang-tidy

More
@godexsoft godexsoft force-pushed the fix/clang-tidy-optional branch from 16005c0 to 3303daf Compare April 21, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DraftRunCI Normally CI does not run on draft PRs. This opts in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant