Conversation
WalkthroughPoetry CLI version is updated from 2.1.1 to 2.2.1 across all four GitHub Actions workflows. Additionally, a safety check is added to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
poetry.lock
Outdated
| # This file is automatically @generated by Poetry 2.2.0 and should not be changed by hand. | ||
| # This file is automatically @generated by Poetry 2.1.1 and should not be changed by hand. |
There was a problem hiding this comment.
Shouldn't downgrade the Poetry version
Patel-Raj11
force-pushed
the
update-dependencies
branch
from
e44ed55 to
94d1924
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
.github/workflows/unit_test.yml (1)
10-10: Poetry bump looks good; ensure Poetry bin is on PATH even on cache hits.You only append $HOME/.local/bin to $GITHUB_PATH when the cache misses. On a cache hit, PATH may not include Poetry, causing “poetry: command not found”. Add an unconditional step to export PATH (or move the echo into its own always-run step). Also consider including runner.os/python-version in the cache key to avoid future cross-OS collisions.
.github/workflows/faucet_test.yml (1)
9-9: OK to bump; mirror the PATH safeguard.Same PATH caveat as other workflows: export $HOME/.local/bin even when cache hits to avoid “poetry” not found. Current matrix spans Python 3.8–3.14; please confirm setup-python resolves 3.14 on the runner you use.
.github/workflows/integration_test.yml (1)
4-4: Bump is fine; add unconditional PATH export for Poetry.Install step appends PATH only on cache miss. Add a tiny, always-run step to echo $HOME/.local/bin to $GITHUB_PATH. Everything else (timeout, matrix, docker health checks) looks solid.
.github/workflows/publish_to_pypi.yml (1)
12-12: Good; align actions/cache to v4 and ensure PATH export.
- Use actions/cache@v4 (others already on v4) for consistency and performance.
- Keep the PATH export for Poetry unconditional (not only on cache miss).
- Nice touch verifying installation and artifact checks.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
.github/workflows/faucet_test.yml(1 hunks).github/workflows/integration_test.yml(1 hunks).github/workflows/publish_to_pypi.yml(1 hunks).github/workflows/unit_test.yml(1 hunks)xrpl/models/utils.py(1 hunks)
| return ( | ||
| dataclass.__kwdefaults__ is not None and "kw_only" in dataclass.__kwdefaults__ | ||
| ) |
There was a problem hiding this comment.
Null‑guard is correct; fix docstring mismatch and a small typo.
- Change improves robustness when dataclass.kwdefaults is None. LGTM.
- Docstring above (Lines 286–301) claims “older than 3.10 ⇒ True”, but the function returns True when kw_only is available (i.e., Python ≥ 3.10). Please correct it; also “higer” → “higher” in the comment on Line 306.
- Optional: consider renaming to has_dataclass_kw_only() for clarity.
🤖 Prompt for AI Agents
In xrpl/models/utils.py around lines 301 to 303, the null-guard logic is fine
but the docstring on lines 286–301 incorrectly states “older than 3.10 ⇒ True”
while the function actually returns True when kw_only exists (Python ≥ 3.10);
update that docstring to state that presence of kw_only indicates Python 3.10 or
newer and correct the typo "higer" to "higher" on line 306; optionally, rename
the function to has_dataclass_kw_only() and update references if you want
clearer intent.
2 participants
High Level Overview of Change
Ran -
poetry updatehttps://python-poetry.org/docs/basic-usage/#updating-dependencies-to-their-latest-versions
Context of Change
Type of Change
Did you update CHANGELOG.md?
Test Plan
Tests in CI should pass