Skip to content

Conversation

@Patel-Raj11
Copy link
Collaborator

@Patel-Raj11 Patel-Raj11 commented Dec 11, 2025

High Level Overview of Change

We no more need react as dev dependency. It was primarily used during build step while generating docs. Removing it was missed during this change - #2910.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update HISTORY.md?

  • Yes
  • No, this change does not impact library users

Test Plan

npm run clean && npm run build && npm run docgen runs fine locally.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025

Walkthrough

The React devDependency has been removed from the xrpl package's package.json manifest. This is a straightforward dependency removal with no structural or script modifications.

Changes

Cohort / File(s) Summary
Dependency Management
packages/xrpl/package.json
Removed React (^19.0.0) from devDependencies

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Straightforward dependency removal with no cascading logic or configuration changes
  • Single-line alteration in manifest file
  • Consider verifying whether any build scripts, test configurations, or component definitions still reference React before merging

Poem

🐰 A React gone, from the garden it hops,
One less dependency, the package now stops,
Lighter and cleaner, our manifest so bright,
The xrpl bundle takes flight!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: removing the React dev dependency from the package.json file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description follows the required template with all key sections completed, including clear context linking to PR #2910, proper classification as a refactor, and verification through documented testing.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-react-dev-dependency

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants