Support frozenBalances in gateway_balances result #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
=========================================
Coverage 92.43% 92.43%
- Complexity 2091 2092 +1
=========================================
Files 430 430
Lines 5673 5674 +1
Branches 506 506
=========================================
+ Hits 5244 5245 +1
Misses 282 282
Partials 147 147 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sappenin
requested changes
Oct 14, 2025
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/client/accounts/GatewayBalancesResult.java
Outdated
Show resolved
Hide resolved
…s/GatewayBalancesResult.java Co-authored-by: David Fuelling <[email protected]>
Collaborator
|
Merging this on grounds of https://github.com/XRPLF/xrpl4j/actions/runs/18480051454, which is a successful build minus the permissioned-domain stuff, which is expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an undocumented field
frozen_balancesin the response togateway_balancesthat contains the balances of all frozen trustlines with the given account. Adding support for that field in this PR.