-
Notifications
You must be signed in to change notification settings - Fork 68
Support Token Escrows #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sappenin
wants to merge
14
commits into
main
Choose a base branch
from
df/support-token-escrows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappenin
commented
Jan 8, 2026
| * @return An {@link Optional} of type {@link String} containing the issuer node hint. | ||
| */ | ||
| @JsonProperty("IssuerNode") | ||
| Optional<String> issuerNode(); |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This is typed as a String to conform to the Hex value returned by the RPC layer. Also aligns with RippleStateObject types like lowNode and highNode`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add XLS-0085 Token Escrow Support (v6.0.0)
Overview
This PR implements support for the XLS-0085 Token Escrow amendment, which extends the existing Escrow functionality to support Trustline-based tokens (IOUs)** and **Multi-Purpose Tokens (MPTs) in addition to XRP.
✨ New Features
1. IOU Token Escrows
ALLOW_TRUSTLINE_LOCKINGflag2. MPT Token Escrows
lsfMPTCanEscrowandlsfMPTCanTransferflags on the tokenMpTokenObjectandMpTokenIssuanceObject3. New AccountSet Flag
ALLOW_TRUSTLINE_LOCKING(17)enum valueAccountRootFlags.ALLOW_TRUSTLINE_LOCKING(0x40000000) constantlsfAllowTrustLineLocking()method for checking account state4. New EscrowObject Fields
transferRate(): Stores the locked transfer rate (IOU) or transfer fee (MPT) at escrow creationissuerNode(): Reference to issuer's directory node when issuer is neither source nor destination5. MPT Locked Amount Tracking
MpTokenObject.lockedAmount(): Tracks amount locked in escrows for a holderMpTokenIssuanceObject.lockedAmount(): Tracks total amount locked across all holders✅ Test Coverage
🚨 Breaking Changes
While all existing XRP escrow functionality remains fully backward compatible, there are some breaking changes required to support IOU and MPT tokens.
Type Changes
EscrowCreate.amount():XrpCurrencyAmount→CurrencyAmountEscrowObject.amount():XrpCurrencyAmount→CurrencyAmountMetaEscrowObject.amount():XrpCurrencyAmount→CurrencyAmountImpact: Code that reads escrow amounts must be updated to handle
CurrencyAmountusing.handle()or.map()methods. Building transactions withXrpCurrencyAmountcontinues to work due to polymorphism.