Skip to content

Conversation

@tequdev
Copy link
Member

@tequdev tequdev commented Oct 17, 2025

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@RichardAH
Copy link
Contributor

what effect does this have on server definitions? Should we modify server_definitions maybe to include duplicates for the aliased types?

@tequdev
Copy link
Member Author

tequdev commented Oct 27, 2025

what effect does this have on server definitions? Should we modify server_definitions maybe to include duplicates for the aliased types?

yes, need to add processing to server_definition.

Also, we need to consider at what point the value of TxJson.TransactionType returned by commands like tx command should be changed to the Alias value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants