FeatureRNG [DO NOT MERGE] #659
Open
+934
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tequdev
reviewed
Jan 5, 2026
Comment on lines
+463
to
+464
| HOOK_API_DEFINITION(I64, dice, (I32)), | ||
| HOOK_API_DEFINITION(I64, random, (I32, I32)), |
Member
There was a problem hiding this comment.
these needs to be Amendment Guarded like import_whitelist_1
Contributor
Author
There was a problem hiding this comment.
good catch I knew I forgot something 😅
RichardAH
commented
Jan 6, 2026
|
|
||
| // ttSHUFFLE is injected as part of featureRNG, based on the proposal | ||
| // signature | ||
| injectShuffleTxn(app_, makeSlice(set.signature())); |
Contributor
Author
There was a problem hiding this comment.
should be only for trusted proposals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)