Closed
Conversation
The build was failing after upgrading the Docsy theme to v0.12.0. This was caused by two breaking changes in the new version: 1. Theme partials were moved from `layouts/partials` to `layouts/_partials`. 2. The `scripts.html` partial was updated to load different JS assets, causing a `resources.Concat` error when our old override was used. This commit fixes the build by: - Renaming the override folder in `xltdoc` to `layouts/_partials`. - Replacing the content of `scripts.html` with the new version from Docsy v0.12.0.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
rbaumgarten
force-pushed
the
docsy-theme-update
branch
from
218c821 to
5f33a16
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Docsy theme to version 0.12.0 by replacing the existing theme files with a Git submodule reference. The update removes all individual theme files and replaces them with a submodule pointer to the official Docsy repository.
- Removes all existing Docsy theme source files (SCSS, JavaScript, JSON, documentation)
- Replaces the theme directory with a Git submodule reference to commit
ace4e37ceedcec9c48d329adb1128201061ef23d - Streamlines theme management by using the official repository instead of maintaining local copies
Reviewed Changes
Copilot reviewed 38 out of 7010 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| themes/docsy/ | Converted from individual files to Git submodule reference pointing to Docsy v0.12.0 |
| Multiple SCSS files | Removed all local SCSS files as they're now managed via submodule |
| Multiple JavaScript files | Removed all local JavaScript files as they're now managed via submodule |
| Documentation files | Removed local copies of README, LICENSE, and contributing guidelines |
| Configuration files | Removed local development configuration files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rbaumgarten
force-pushed
the
docsy-theme-update
branch
from
d27d228 to
5892291
Compare
rbaumgarten
force-pushed
the
docsy-theme-update
branch
from
dee4ef4 to
096da47
Compare
rbaumgarten
force-pushed
the
docsy-theme-update
branch
from
35793e4 to
ecdd31d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.