Skip to content

Potential fix for code scanning alert no. 4: Incomplete URL substring sanitization #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Xenonesis wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 4: Incomplete URL substring sanitization #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion components/ui/team.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,13 @@ export default function TeamSection() {
onError={(e) => {
// Fallback to a placeholder if image fails to load
const target = e.currentTarget;
if (!target.src.includes('ui-avatars.com')) {
try {
const url = new URL(target.src);
if (url.hostname !== 'ui-avatars.com') {
target.src = `https://ui-avatars.com/api/?name=${encodeURIComponent(member.name)}&background=6366f1&color=fff&size=200&bold=true`;
}
} catch (error) {
// If the URL constructor fails, fall back to setting the default
target.src = `https://ui-avatars.com/api/?name=${encodeURIComponent(member.name)}&background=6366f1&color=fff&size=200&bold=true`;
}
}}
Expand Down