Skip to content

Conversation

@gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Oct 29, 2025

Proposed changes

Notice: strings.SplitSeq() is introduced in Go 1.24

The strings.SplitSeq function in Go is a new addition (introduced in Go 1.24) that provides an iterator for splitting a string. Unlike strings.Split, which returns a []string (a slice of strings), SplitSeq returns a single-use iterator. This iterator yields the same substrings that Split would produce, but it does so without constructing the entire slice in memory at once.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan changed the title all: use strings.SplitSeq() to range strings.Split() all: ranging over strings.SplitSeq is more efficient than strings.Split Oct 29, 2025
@gzliudan gzliudan changed the title all: ranging over strings.SplitSeq is more efficient than strings.Split all: range strings.SplitSeq is more efficient than strings.Split Oct 29, 2025
@gzliudan gzliudan force-pushed the use-strings-SplitSeq branch from 154bc3f to e56436e Compare October 29, 2025 03:42
@gzliudan gzliudan changed the title all: range strings.SplitSeq is more efficient than strings.Split all: range over strings.SplitSeq is more efficient than strings.Split Oct 29, 2025
@gzliudan gzliudan changed the title all: range over strings.SplitSeq is more efficient than strings.Split all: replace strings.Split with more efficient strings.SplitSeq Oct 29, 2025
@gzliudan gzliudan force-pushed the use-strings-SplitSeq branch from e56436e to 0a0b92e Compare October 29, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant