✨ Add literal values support in search #454
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the search functionality in Xircuits by including literal values stored in port labels, in addition to node names.
This makes it easier for users to quickly locate nodes by their literal string contents, not just by node names.
Key Changes
collectLiteralValues
helper to gatherport.label
values.searchModel
to match against:options.name
)port.label
)Pull Request Type
Type of Change
Tests
Print
,BranchComponent
) → nodes correctly matched.True
,Xircuits
,Hello
) → literal nodes correctly matched.BranchComponent
) were not included in search results.Tested on? Specify Version.