Fix setter type inference #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the "Fix setter type inference" bug by updating test cases and internal logic to accurately handle setter and getter distinctions during type inference for throw annotations.
- Updated tests in no-undocumented-throws and check-throws-tag-type to verify correct error reporting for getters and setters
- Modified getCalleeDeclaration in utils.js to properly identify setter declarations and adjusted no-undocumented-throws rule logic accordingly
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/rules/no-undocumented-throws.test.js | Added test cases for getter/setter usage with expected throws documentation |
| tests/rules/check-throws-tag-type.test.js | Updated tests to catch mismatches in documented throw types for setter/getter usage |
| src/utils.js | Enhanced type inference by explicitly checking for setter declarations and removed redundant switch logic |
| src/rules/no-undocumented-throws.js | Refined rule to exclude getter throw types in assignment contexts, focusing on setters |
Xvezda
force-pushed
the
feature/fix-setter-type-infer
branch
from
c301290 to
9bbe355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.