Add narrowing tests #139
Add narrowing tests #139
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds new test cases to verify throwing behavior in narrowed getter/setter contexts for two ESLint rules.
- Introduces tests for
no-undocumented-throwsto ensure missing@throwstags are reported in narrowed branches. - Adds tests for
check-throws-tag-typeto validate mismatched@throwsannotations in similar scenarios.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/rules/no-undocumented-throws.test.js | New test block for getter/setter narrowing checks |
| tests/rules/check-throws-tag-type.test.js | New test block for throw type mismatch checks |
| }, | ||
| { | ||
| code: ` | ||
| class TrueGetterError extends Error {} |
There was a problem hiding this comment.
[nitpick] The error class and foo setup are duplicated in multiple test files; consider extracting shared fixtures or helper functions to reduce repetition and improve maintainability.
Copilot uses AI. Check for mistakes.
| }, | ||
| { | ||
| code: ` | ||
| class TrueGetterError extends Error {} |
There was a problem hiding this comment.
[nitpick] This block duplicates the same class definitions and foo function from another test; refactoring into a shared helper would make the tests easier to maintain.
Copilot uses AI. Check for mistakes.
1 participant
No description provided.