Skip to content

Conversation

Xvezda
Copy link
Owner

@Xvezda Xvezda commented Jun 28, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 28, 2025 00:05
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR "Update types" updates test cases for the throws tag validation rules and adjusts dependency versions accordingly.

  • Removed outdated test cases in no-undocumented-throws and check-throws-tag-type tests
  • Updated dependency names and versions in package.json and added a new .npmrc configuration

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
tests/rules/no-undocumented-throws.test.js Removed a test case that expected an undocumented throws tag
tests/rules/check-throws-tag-type.test.js Removed a test case for a type mismatch in throws tags
package.json Updated dependency names and versions to new dev versions
.npmrc Added public hoist configuration for TypeScript packages
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

tests/rules/no-undocumented-throws.test.js:3200

  • The removal of this test case for the missing @throws tag may reduce test coverage for undocumented throws. Please verify that the intended behavior is still adequately tested elsewhere.
      {

tests/rules/check-throws-tag-type.test.js:1301

  • The removal of the test case for throw type mismatches might affect coverage for the updated behavior expecting a RangeError. Confirm that the revised logic is sufficiently validated by other tests.
      {

@Xvezda Xvezda merged commit fc18251 into master Jun 28, 2025
1 check passed
@Xvezda Xvezda deleted the feature/update-types branch June 28, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant