Repository navigation
deps: bump ratatui, crossterm, tui-input and arrow; clippy::performance - #202
Merged
YS-L merged 10 commits intoJul 4, 2026
Merged
Conversation
now that ratatui has been updated to 0.30 also lock file update as well for other dependencies
jqnatividad
changed the title
warning: consider using `sort_by_key`
--> src/csv.rs:224:9
|
224 | get_row_indices.sort_by(|a, b| a.record_index.cmp(&b.record_index));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
= note: `#[warn(clippy::unnecessary_sort_by)]` on by default
help: try
|
224 - get_row_indices.sort_by(|a, b| a.record_index.cmp(&b.record_index));
224 + get_row_indices.sort_by_key(|a| a.record_index);
|
warning: you seem to want to iterate on a map's values
--> src/history.rs:87:29
|
87 | for (_, history) in self.inner.iter_mut() {
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
= note: `#[warn(clippy::for_kv_map)]` on by default
help: use the corresponding method
|
87 - for (_, history) in self.inner.iter_mut() {
87 + for history in self.inner.values_mut() {
|
jqnatividad
changed the title
Contributor
Author
|
@YS-L also bumped MSRV to latest stable, and the lock file. Had to touch GH Action workflows as well to use latest Rust stable, but didn't want to mess up your cargo-dist. |
YS-L
reviewed
Jul 1, 2026
| repository = "https://github.com/YS-L/csvlens" | ||
| keywords = ["cli", "csv", "viewer", "pager", "tui"] | ||
| edition = "2024" | ||
| rust-version = "1.88" |
Owner
There was a problem hiding this comment.
Curious whether the MSRV bump to 1.96 is required. I'd prefer not to raise it unless a dependency or code change requires it.
Contributor
Author
There was a problem hiding this comment.
MSRV bump is not required. Bumped it back down...
While I was at it bumped arrow as well :)
YS-L
changed the title
Owner
|
Thanks @jqnatividad ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now that ratatui has been updated to 0.30
also lock file update as well for other dependencies