Flink restart support - trying out security check#4332
Closed
tub wants to merge 3 commits into
Closed
Conversation
Instead of printing "unsupported" and telling users to manually stop + start, send desired_state="restart" via the instance_set_state API. The flink-operator handles the full stop→start cycle atomically. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Tests now verify that paasta restart calls instance_set_state("restart")
for Flink instances instead of asserting on the old "unsupported" message.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Replace heavy === separators with clean section headers (Links, Monitoring, Logs) - Add OSC 8 terminal hyperlinks with y/ short-link labels as fallback - Move metadata/links/monitoring to the end (state/pods/jobs first) - Shorten pod hostnames by stripping cloud DNS suffixes - Show desired_state when it differs from actual (e.g. "desired: restart") - Add PaastaColors.terminal_link() utility for OSC 8 hyperlinks Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
as expected, nothing from the security review check :p |
Member
|
(i'll also close this so that we can centralize reviews in the OG PR: #4330) |
nleigh
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
desired_state="restart"via the existinginstance_set_stateAPIRefactors the flink paasta status output to be less verbose:
Depends on
Test plan
paasta restart -s <flink-service> -i <instance> -c <cluster>triggers operator restart🤖 Generated with Claude Code