IBM Dataloader - #19
Open
ProgerDav wants to merge 7 commits into
Open
Conversation
Co-authored-by: Linsong Chu <lchu@us.ibm.com>
Re-sync fork to main, and add the latest features from fms-fsdp: - Remove dependence on the separate metadata "count file" in the dataset directory - Support n_workers > 1. This is accomplished by shunting all path/rank-dependent setup out of initialization and into a new setup() method, which runs after init but before any other op - Support HF-style parquet raw text datasets, with tokenization on the fly (for reasonably sized documents/shardfiles) - Support non-flat data directories: all legal files under the specified location will be included, regardless of depth or location. Enables simple weight-free dataset mixing via a single `StreamingDocDataset` on the parent directory - `SamplingDataset` and `ScalableShardDataset`are now implemented as proper `_WrapperDatasets`, reflecting the intended modular usage - Fix Weird_Separated_Camel_Case naming convention in favor of ProperClassNaming - Allow `PreloadBufferDataset` to shrink back down to the desired size after rescaling to a smaller number of workers
philippguevorguian
marked this pull request as draft
September 10, 2024 12:02
ProgerDav
marked this pull request as ready for review
September 10, 2024 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.