Perf/adaptfx core hotpath optimizations#9
Open
timsoleskos wants to merge 24 commits into
Open
Conversation
…e loops with lighter NumPy-based paths
…otpath-optimizations
…-hotpath-optimizations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the existing 3D adaptive fractionation core faster and cleaner (without carrying over my 5D extension).
In CI, the reported pytest runtime drops from 3.09s on
masterto 2.28s on this branch, which is about a 26% reduction. The full workflow remains mostly setup-bound, so the wall-clock CI improvement is smaller.Main changes:
get_state_space/probdistto work from(mean, std)tuples, and updates internal call sites accordingly.policy_calc, keeping it as a notebook/visualization helper while routing it through the newer helper flow.precompute_planby reusing the candidate-volume buffer and continuing the scan until both the relevant volume range and minimum-policy condition are reached.INFEASIBLE_VALUE, dose-grid tolerances, and the precompute scan assumptions.slowtest markers now that the suite runs quickly.