Skip to content

⚡ Bolt: Fix HFT bot detection crash and optimize with NumPy#82

Open
Yog-Sotho wants to merge 1 commit into
masterfrom
bolt-hft-optimization-5666329305103599659
Open

⚡ Bolt: Fix HFT bot detection crash and optimize with NumPy#82
Yog-Sotho wants to merge 1 commit into
masterfrom
bolt-hft-optimization-5666329305103599659

Conversation

@Yog-Sotho

Copy link
Copy Markdown
Owner

Identified a NameError in the high-frequency bot detection heuristic where variables were used before initialization. Optimized the entire function by vectorizing statistical calculations using NumPy (np.diff, np.mean, np.std) and pre-extracting trade attributes into NumPy arrays to eliminate SQLAlchemy ORM overhead. Also hoisted configuration threshold lookups outside the sender loop and cleaned up redundant imports. Verified with a reproduction script.


PR created automatically by Jules for task 5666329305103599659 started by @Yog-Sotho

Identified a NameError in the high-frequency bot detection heuristic where
variables were used before initialization. Optimized the entire function by:
1. Vectorizing statistical calculations using NumPy (np.diff, np.mean, np.std).
2. Pre-extracting trade attributes into NumPy arrays to eliminate SQLAlchemy ORM overhead.
3. Hoisting configuration threshold lookups outside the sender loop.
4. Cleaning up redundant imports in core/heuristics.py.

Measurement: Verified with scripts/reproduce_hft_bug.py, identifying 1000 wash trades in ~0.01s.

Co-authored-by: Yog-Sotho <263140117+Yog-Sotho@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant