WIP Enhance LinkedList with new methods#33
Open
vmasto wants to merge 1 commit intoYomguithereal:masterfrom
Open
WIP Enhance LinkedList with new methods#33vmasto wants to merge 1 commit intoYomguithereal:masterfrom
vmasto wants to merge 1 commit intoYomguithereal:masterfrom
Conversation
Adds #find, #findLast, #addBefore, #addAfter
Owner
|
Hello @vmasto. Thanks for the PR. I think we need to change some things about the |
Author
|
Makes sense to use |
Owner
|
Sure. Just ping me back if I forget. |
Author
|
Ping :D |
Owner
|
I am still reflecting on how to change the API if we go the node class way. Because it might feel strange if some methods return a node and other ones don't. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This PR aims to add a few more helpful methods in the Linked List implementation. If you so approve we could add more and once the API is finalized I'd be happy to implement a Doubly Linked List.
I'm aware of issue #18 but I'd need a few more details on what methods you'd like to be added.