Skip to content

feat: add an allow list to security checker #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Upstream projects not having phpunit installed will install phpunit with an @stable version.
- Added support for Drupal configuration and templates.
- Migration docs for migration from v2 to v3 of the testing suite.
- Added support for an Allow List within the Security Checker.

### Changed
- [BREAKING] The composer.json configurations `config.youwe-testing-suite.type` and `config.mediact-testing-suite.type`
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"kint-php/kint": "@stable",
"php-parallel-lint/php-parallel-lint": "^1.4",
"phpmd/phpmd": "^2.15",
"phpro/grumphp-shim": "^2.12",
"phpro/grumphp-shim": "^2.15",
"phpstan/phpstan": "@stable",
"squizlabs/php_codesniffer": "^3.12.0",
"youwe/composer-dependency-installer": "^2.0",
Expand Down
2 changes: 2 additions & 0 deletions config/default/grumphp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ parameters:

securitychecker.lockfile: ./composer.lock
securitychecker.run_always: true
securitychecker.allow_list: []

git_blacklist.keywords:
- "die("
Expand Down Expand Up @@ -132,3 +133,4 @@ grumphp:
securitychecker_enlightn:
lockfile: '%securitychecker.lockfile%'
run_always: '%securitychecker.run_always%'
allow_list: '%securitychecker.allow_list%'
6 changes: 5 additions & 1 deletion config/drupal/grumphp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,8 @@ imports:

# Extend git triggers with common Drupal constructs
parameters:
git_blacklist.triggered_by: [ 'php', 'js', 'twig' ]
git_blacklist.triggered_by: [ 'php', 'js', 'twig' ]

# securitychecker.allow_list:
# - CVE-2002-0121 # Add a jira ticket indicating when this vulnerability will be fixed (update/upgrade will be
# performed). Within that ticket explain this (new) vulnerability.
4 changes: 4 additions & 0 deletions config/magento2/grumphp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,7 @@ parameters:
- "<?php echo"
- "Magento\\\\Framework\\\\App\\\\ObjectManager"
git_blacklist.triggered_by: [ 'php', 'js', 'phtml' ]

# securitychecker.allow_list:
# - CVE-2002-0121 # Add a jira ticket indicating when this vulnerability will be fixed (update/upgrade will be
# performed). Within that ticket explain this (new) vulnerability.
6 changes: 5 additions & 1 deletion config/pimcore/grumphp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,8 @@ imports:

# Extend git triggers with common pimcore constructs
parameters:
git_blacklist.triggered_by: [ 'php', 'js', 'twig' ]
git_blacklist.triggered_by: [ 'php', 'js', 'twig' ]

# securitychecker.allow_list:
# - CVE-2002-0121 # Add a jira ticket indicating when this vulnerability will be fixed (update/upgrade will be
# performed). Within that ticket explain this (new) vulnerability.