feat(Global header): Add custom logo slot and part#189
Merged
thelukewalton merged 4 commits intomainfrom Mar 24, 2026
Merged
Conversation
Contributor
|
Visit the preview URL for this PR (updated for commit 3b7e43a): https://zeta-web-main--pr-189-global-header-logo-zqou7mj1.web.app (expires Tue, 31 Mar 2026 10:28:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: cc82fb52ba05c9ecc7f0b92ab81ac4a31b88d893 |
Contributor
PR Checks Complete✅ Analysis✅ Formatting✅ Testing➡️ See Details
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the zeta-global-header component to support a custom logo via a named slot and exposes a logo part for styling, while also adjusting CI behavior and bumping several dev dependencies.
Changes:
- Add a
logoslot andlogopart tozeta-global-header(default Zebra logo vs custom slotted logo). - Update Global Header Storybook story to demonstrate custom logo usage.
- CI/workflow tweak to ignore whitespace-only diffs for the auto-commit step, plus dependency updates.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/components/global-header/global-header.ts |
Introduces logo slot + logo part and switches rendering logic for default vs custom logo. |
src/components/global-header/global-header.styles.js |
Updates internal styling selectors to target the new part="logo" container. |
src/stories/components/global-header.stories.ts |
Adds customLogo arg and slotted logo examples in Storybook. |
.github/workflows/pull-request.yml |
Adjusts diff detection to ignore whitespace changes before auto-committing generated files. |
package.json |
Bumps TypeScript ESLint, TypeDoc, and typescript-eslint versions. |
yarn.lock |
Lockfile updates for the bumped dependencies/transitives. |
.gitignore |
Ignores .claude/ directory. |
src/index.ts |
Whitespace-only formatting change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aygurs
approved these changes
Mar 24, 2026
deps: Update packages
thelukewalton
force-pushed
the
global-header-logo
branch
from
6579114 to
95405c7
Compare
thelukewalton
force-pushed
the
global-header-logo
branch
from
f9d889c to
3b7e43a
Compare
thelukewalton
added a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- ## [1.3.0](zeta-web-v1.2.3...zeta-web-v1.3.0) (2026-03-24) ### ✨ New Features * **Global header:** Add custom logo slot and part ([#189](#189)) ([486cddd](486cddd)) ### 🧹 Miscellaneous Chores * **deps:** bump flatted from 3.3.3 to 3.4.2 ([#187](#187)) ([933b10b](933b10b)) ### 👷 Continuous Integration * Ignore whitespace in pr action ([486cddd](486cddd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
thelukewalton
added a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- [1.2.4](zeta-web-v1.2.3...zeta-web-v1.2.4) (2026-03-24) * **Global header:** Add custom logo slot and part ([#189](#189)) ([486cddd](486cddd)) * **deps:** bump flatted from 3.3.3 to 3.4.2 ([#187](#187)) ([933b10b](933b10b)) * Ignore whitespace in pr action ([486cddd](486cddd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci: Ignore whitespace in pr action
deps: Update packages