fix(HMX-9126): Fix zeta select input and option for long inputs#194
Merged
thelukewalton merged 3 commits intomainfrom Apr 7, 2026
Merged
fix(HMX-9126): Fix zeta select input and option for long inputs#194thelukewalton merged 3 commits intomainfrom
thelukewalton merged 3 commits intomainfrom
Conversation
Contributor
|
Visit the preview URL for this PR (updated for commit b3b88df): https://zeta-web-main--pr-194-hmx-9126-d2b4wefg.web.app (expires Tue, 14 Apr 2026 10:45:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: cc82fb52ba05c9ecc7f0b92ab81ac4a31b88d893 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses truncation/overflow issues for long placeholder/selected text in zeta-select-input and long option labels in zeta-option by introducing dedicated part wrappers and corresponding truncation styles.
Changes:
- Wrap select input display text in a new
part="input-text"span and add ellipsis truncation styling. - Wrap option slot content in a new
part="option-text"span and add multi-line clamping styling. - Add/extend tests for the new parts and update the Storybook story to exercise long option content.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/select-input/select-input.test.ts | Updates assertions and adds coverage for the new input-text part behavior. |
| src/test/select-input/option.test.ts | Adds new tests validating option-text part and interaction events. |
| src/stories/components/Select Input/select-input.stories.ts | Adjusts story layout and adds a long option label to demo truncation behavior. |
| src/components/select-input/select-input.ts | Introduces @part input-text and renders placeholder/selected text inside it. |
| src/components/select-input/select-input.styles.js | Adds truncation styling for [part="input-text"] and prevents icon shrinking. |
| src/components/select-input/option.ts | Wraps option slot in part="option-text" span. |
| src/components/select-input/option.styles.js | Attempts to set host display and adds line-clamp styling for [part="option-text"]. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
PR Checks Complete✅ Analysis✅ Formatting✅ Testing➡️ See Details
|
aygurs
approved these changes
Apr 7, 2026
thelukewalton
added a commit
that referenced
this pull request
Apr 7, 2026
🤖 I have created a release *beep* *boop* --- ## [1.2.6](zeta-web-v1.2.5...zeta-web-v1.2.6) (2026-04-07) ### 🪲 Bug Fixes * **HMX-9126:** Fix zeta select input and option for long inputs ([#194](#194)) ([005a206](005a206)) ### ⛓️ Dependencies * Update deps ([8659827](8659827)) ### 🧹 Miscellaneous Chores * **deps-dev:** bump vite from 6.4.1 to 6.4.2 ([#195](#195)) ([0411cb5](0411cb5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.