Merged
Conversation
aygurs
approved these changes
Apr 16, 2026
Contributor
|
Visit the preview URL for this PR (updated for commit be92c39): https://zeta-web-main--pr-201-noticket-textarea-ss2xgjz2.web.app (expires Thu, 23 Apr 2026 15:17:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: cc82fb52ba05c9ecc7f0b92ab81ac4a31b88d893 |
Contributor
|
hello |
Contributor
PR Checks Complete✅ Analysis✅ Formatting✅ Testing➡️ See Details
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for configuring the number of visible lines for textarea mode by introducing a rows property on zeta-text-input and forwarding it to the underlying <textarea> rendered by the shared FormField mixin.
Changes:
- Add
rowsproperty toZetaTextInput(defaulting to 2). - Forward
rowsto the<textarea>element inFormFieldwhentype === "textarea".
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/mixins/form-field.ts | Forwards a rows value into the rendered <textarea> for textarea-type fields. |
| src/components/text-input/text-input.ts | Introduces a rows API on zeta-text-input intended for textarea mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix: Address comments
aygurs
pushed a commit
that referenced
this pull request
Apr 16, 2026
🤖 I have created a release *beep* *boop* --- ## [1.2.8](zeta-web-v1.2.7...zeta-web-v1.2.8) (2026-04-16) ### 🪲 Bug Fixes * Add rows to text area ([#201](#201)) ([19383d3](19383d3)) ### ⛓️ Dependencies * update deps ([a8f17a6](a8f17a6)) ### 🧹 Miscellaneous Chores * Update Input types to have better support for inputs ([#199](#199)) ([2566adf](2566adf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.