chore: Add .js to imports for packages that require fully qualified imports#23
Merged
thelukewalton merged 6 commits intomainfrom Mar 21, 2025
Merged
chore: Add .js to imports for packages that require fully qualified imports#23thelukewalton merged 6 commits intomainfrom
thelukewalton merged 6 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures fully qualified module import paths by appending the .js extension to various package imports.
- Updates import paths across multiple component files.
- Aligns module imports with the bundler’s requirements by adding the .js extension.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/radio-button/radio-button-controller.ts | Updated import for radio button mixin. |
| src/components/navigation-rail/navigation-rail-item.ts | Added .js extensions to mixin and module imports. |
| src/components/select-input/select-input.ts | Updated mixin and icon imports to include .js suffix. |
| src/components/dropdown/dropdown-menu/dropdown-menu-button.ts | Added .js extension for droppable import. |
| src/components/segmented-control/segmented-item.ts | Updated import for contour mixin with .js extension. |
| src/components/chips/base-chips/interactive-chip.ts | Updated BaseChip import to include .js; note potential typo in class name. |
| src/components/grid-menu-item/grid-menu-item.ts | Updated import for indicators module with .js suffix. |
| src/components/upload-item/upload-item.ts | Corrected icon and progress indicator imports to add .js. |
| src/components/segmented-control/segmented-control.ts | Adjusted imports for contour and segmented item with .js extensions. |
| src/components/navigation-rail/navigation-rail.ts | Updated import for contour mixin with .js extension. |
| src/components/base-toggle-form-element.ts | Adjusted icon import to include .js extension. |
Comments suppressed due to low confidence (1)
src/components/chips/base-chips/interactive-chip.ts:4
- The class name 'InterativeChip' appears to contain a typo; consider renaming it to 'InteractiveChip' for clarity.
export class InterativeChip extends BaseChip {
Contributor
PR Checks Complete✅ Analysis✅ Formatting✅ Testing➡️ See Details
|
Contributor
|
Visit the preview URL for this PR (updated for commit 46947be): https://zeta-web-main--pr-23-chore-js-4h4duroi.web.app (expires Fri, 28 Mar 2025 12:12:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: cc82fb52ba05c9ecc7f0b92ab81ac4a31b88d893 |
DE7924
approved these changes
Mar 21, 2025
thelukewalton
added a commit
that referenced
this pull request
Mar 21, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.1](zeta-web-v0.4.0...zeta-web-v0.4.1) (2025-03-21) ### 🪲 Bug Fixes * Radio button checked is bool not string ([#24](#24)) ([ab73b76](ab73b76)) ### 📈 Documentation * Fix misssplled figma ([b35b915](b35b915)) ### 🧹 Miscellaneous Chores * Add .js to imports for packages that require fully qualified imports ([#23](#23)) ([fb6ee75](fb6ee75)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.