Skip to content

Conversation

chcmedeiros
Copy link
Contributor

@chcmedeiros chcmedeiros commented Oct 8, 2025

🔗 zboto Link

Copy link

Summary of Changes

Hello @chcmedeiros, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR introduces code coverage and sanitizer build configurations to the CMake setup, making them conditional on specific flags and compiler types. It also updates the application's patch version.

Highlights

  • Intent: This pull request aims to integrate code coverage into the project's Continuous Integration (CI) pipeline. It introduces conditional compilation flags for coverage and sanitizers, ensuring they are applied correctly based on the build configuration.
  • Changes: The primary changes are in CMakeLists.txt, where logic has been added to enable code coverage flags (-fprofile-instr-generate -fcoverage-mapping for Clang, --coverage for GCC) and sanitizers (-fsanitize=address,undefined) based on ENABLE_COVERAGE and ENABLE_SANITIZERS CMake options, respectively. These configurations are applied only when fuzzing is not enabled, as fuzzing has its own coverage setup. The fuzzing configuration include (FuzzingCommon.cmake) was also made conditional. Additionally, CMakeLists.txt now explicitly helps CMake find thread libraries. The app/Makefile.version file was updated to increment the patch version from 0 to 1.
  • Reviewer Activity: No specific reviewer activity has been recorded for this pull request yet.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/coverage.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@chcmedeiros chcmedeiros requested a review from abenso October 8, 2025 07:58
Copy link

github-actions bot commented Oct 8, 2025

Code Coverage Report 📊

C++ Coverage

Metric Coverage
Lines 49.6% (1221 of 2461 lines)
Functions 46.6% (179 of 384 functions)
Branches no data found

📊 Total Project Coverage

Metric Coverage
Lines 49.6% (1221 of 2461 lines)
Functions 46.6% (179 of 384 functions)
Branches no data found

Warning: Coverage (49.6%) is below the required threshold (50%)

@chcmedeiros
Copy link
Contributor Author

@abenso ready for review now, in case you want to merge in dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant