DCQL send raw VcJws when not requiring cryptographic holder binding #516
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@codex review |
acrusage-iaik
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87e9407b6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/openid/OpenId4VpVerifier.kt
Show resolved
Hide resolved
…ing=false to validate that verification still succeeds
acrusage-iaik
changed the title
…entationRequestBuilder.kt
…entationRequestBuilder.kt
nodh
left a comment
nodh
left a comment
There was a problem hiding this comment.
I really like the new structure, it makes the code much more readable.
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/iso/Iso180137AnnexCVerifier.kt
Show resolved
Hide resolved
vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/openid/OpenId4VpVerifier.kt
Show resolved
Hide resolved
vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/openid/OpenId4VpRequestOptions.kt
Show resolved
Hide resolved
vck-openid/src/commonTest/kotlin/at/asitplus/wallet/lib/openid/OpenId4VpCombinedProtocolTest.kt
Outdated
Show resolved
Hide resolved
vck-openid/src/commonTest/kotlin/at/asitplus/wallet/lib/openid/OpenId4VpEuRefInteropTest.kt
Show resolved
Hide resolved
vck-openid/src/commonTest/kotlin/at/asitplus/wallet/lib/openid/OpenId4VpRequestOptionsTest.kt
Show resolved
Hide resolved
This ranks among the highest honors for a software developer |
nodh
left a comment
nodh
left a comment
There was a problem hiding this comment.
Once we decide on the issue about Signed vs VpJws or VcJws (see comment) this is good to go
2 participants
Uh oh!
There was an error while loading. Please reload this page.