harden: validate trace_length in verifier, remove dead bump allocator#1388
Merged
0xAndoroid merged 2 commits intomainfrom Mar 31, 2026
Merged
harden: validate trace_length in verifier, remove dead bump allocator#13880xAndoroid merged 2 commits intomainfrom
0xAndoroid merged 2 commits intomainfrom
Conversation
Contributor
sagar-a16z
commented
Mar 31, 2026
sagar-a16z
commented
- Add is_power_of_two() and max_padded_trace_length bounds check for proof.trace_length in the verifier, mirroring the existing ram_K validation (H-001)
- Delete jolt-platform/src/alloc.rs (dead code, never compiled — no mod declaration in lib.rs) and remove the dummy _HEAP_PTR symbol from jolt-sdk (H-002)
- Add is_power_of_two() and max_padded_trace_length bounds check for proof.trace_length in the verifier, mirroring the existing ram_K validation (H-001) - Delete jolt-platform/src/alloc.rs (dead code, never compiled — no mod declaration in lib.rs) and remove the dummy _HEAP_PTR symbol from jolt-sdk (H-002)
sagar-a16z
requested review from
0xAndoroid,
markosg04 and
moodlezoup
as code owners
- Add HEADER_MAGIC canary to AllocHeader, validated on free/realloc - Poison magic before dealloc to prevent double-free - Replace from_size_align_unchecked with checked alloc_layout() path - Bad pointers in free no-op; bad pointers in realloc return null
0xAndoroid
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.