Clarify the security of the ecdsa_verify functions for secp256k1 and P256#1391
Merged
sagar-a16z merged 3 commits intoa16z:mainfrom Apr 1, 2026
Merged
Clarify the security of the ecdsa_verify functions for secp256k1 and P256#1391sagar-a16z merged 3 commits intoa16z:mainfrom
ecdsa_verify functions for secp256k1 and P256#1391sagar-a16z merged 3 commits intoa16z:mainfrom
Conversation
mathmasterzach
requested review from
0xAndoroid,
moodlezoup and
sagar-a16z
as code owners
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
sagar-a16z
approved these changes
Apr 1, 2026
0xAndoroid
added a commit
that referenced
this pull request
Apr 2, 2026
Move input validation into ecdsa_verify() for both secp256k1 and P-256, and restrict _unchecked constructors to pub(crate). Addresses the security footgun documented in PR #1391.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added comments to
ecdsa_verifyassumes inputs are well formed and