-
Notifications
You must be signed in to change notification settings - Fork 109
feat: implement server interceptor at handler level #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: implement server interceptor at handler level #241
Conversation
Summary of ChangesHello @guglielmo-san, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust server-side interceptor pattern for the request handling layer. It enables developers to inject custom logic both before and after the execution of any Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request implements a server-side interceptor for request handlers, which is a significant feature for managing cross-cutting concerns. The implementation uses the Decorator pattern to wrap the DefaultRequestHandler and introduce before and after hooks. The new RequestHandlerInterceptor class, along with its supporting interfaces and types, is well-designed. The pull request also includes a comprehensive suite of tests for the new functionality. I have identified a potential race condition in the streaming implementation due to missing await calls and have also provided a suggestion to improve the design's flexibility and testability by applying the Dependency Inversion Principle.
Description
Implement server interceptor, before and after the call to the default request handler.
Interceptors support "early return" both before and after handler invocation. For early return before handler invocation, only "after" methods of executed interceptors are invoked.
Release-As: 0.3.6