Skip to content

Conversation

@2squirrelsai
Copy link

Summary

Adds a CLAUDE.md file to provide comprehensive guidance for Claude Code instances working in this repository.

What's Included

  • Project overview with links to related repositories
  • Clear repository structure showing the agent/host pattern
  • Comprehensive commands for all 5 languages (Python, Java, JavaScript, Go, .NET)
  • Python-specific details (UV workspace, testing, formatting)
  • Code quality standards from .ruff.toml
  • Demo application architecture
  • Security considerations for untrusted agents
  • Extensions overview
  • Contributing guidelines reference

Purpose

This file helps future instances of Claude Code be productive more quickly by providing:

  • Common development commands (build, test, lint)
  • High-level architecture patterns that require reading multiple files to understand
  • Language-specific tooling and workflows
  • Repository-specific code quality standards

The file is concise (267 lines), scannable, and focuses on information that isn't obvious from the file structure alone.

🤖 Generated with Claude Code

Provides comprehensive guidance for Claude Code instances working in this
repository, including development commands, architecture patterns, code
quality standards, and security considerations across all supported languages.

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @2squirrelsai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a dedicated documentation file, CLAUDE.md, designed to serve as a comprehensive guide for AI agents, specifically Claude Code, operating within the repository. The goal is to streamline the development process by centralizing essential information on project structure, development workflows, code standards, and security, thereby enabling AI instances to contribute more effectively and efficiently.

Highlights

  • New Documentation for AI-Assisted Development: A new file, CLAUDE.md, has been added to provide comprehensive guidance specifically for Claude Code instances working within this repository, aiming to enhance productivity and understanding.
  • Comprehensive Development Guide: The document details the project overview, repository structure, and common development commands for five programming languages: Python, Java, JavaScript/TypeScript, Go, and .NET.
  • Code Quality and Standards: It outlines Python-specific style guides, linting, and formatting practices using Ruff, including enabled rule sets and notable ignored rules for maintaining code quality.
  • Demo Application Architecture and Security: The file describes the architecture of the demo web application, its components, features, container deployment, and critical security considerations regarding untrusted agents and prompt injection risks.
  • Protocol Extensions and Frameworks: Information is provided on protocol extensions and the various Python frameworks (e.g., CrewAI, LangGraph, LlamaIndex) used for agent implementations within the samples/python/agents/ directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a CLAUDE.md file to guide AI-assisted development in the repository. The document is comprehensive and well-structured, covering project overview, architecture, development commands for multiple languages, code quality standards, and more. My review focuses on ensuring the accuracy and clarity of the development commands. I've suggested a few corrections to the JavaScript and .NET commands to prevent errors and improve usability, and a minor formatting fix for consistency. Overall, this is an excellent addition that will be very helpful for developers and AI assistants working with this codebase.

```bash
cd samples/js
pnpm install
pnpm run build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pnpm run build command will fail because the build script is not defined in samples/js/package.json. The other scripts use tsx for on-the-fly execution, which suggests a separate build step might not be required for the development workflows described here. I recommend removing this line for accuracy.

Comment on lines +151 to +155
cd samples/dotnet
dotnet restore
dotnet build
dotnet run
dotnet test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The dotnet run command is likely to fail without specifying a project, as the solution in samples/dotnet/BasicA2ADemo contains multiple runnable projects. Also, the commands should be run from the solution directory. I suggest updating the commands to be more specific and accurate for a better developer experience.

Suggested change
cd samples/dotnet
dotnet restore
dotnet build
dotnet run
dotnet test
cd samples/dotnet/BasicA2ADemo
dotnet restore
dotnet build
# Run a specific project (e.g., SimpleClient)
dotnet run --project SimpleClient
dotnet test

│ ├── go/ # JSON-RPC 2.0 compliant implementation
│ └── dotnet/ # .NET 9.0 samples with Semantic Kernel
├── extensions/ # Protocol extensions (AGP, secure-passport, timestamp, traceability)
├── demo/ui/ # Mesop web app demo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

For better readability and consistency, the comment for demo/ui should be aligned with the other comments in the repository structure diagram.

Suggested change
├── demo/ui/ # Mesop web app demo
├── demo/ui/ # Mesop web app demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants